On Thu, Jan 2, 2020 at 1:59 PM Gregory Nutt <spudan...@gmail.com> wrote: > > Still don't see it > > On 1/2/2020 11:19 AM, Nathan Hartman wrote: > > On Thu, Jan 2, 2020 at 12:05 PM Gregory Nutt <spudan...@gmail.com> wrote: > >>> Recently this warning started showing up in builds: > > ... > >>> Patch attached. > >> I don't see anything attached. > > It would help if I attached the file. :-) > > > > Retrying...
Please tell me if two patches appear now... Thanks, Nathan
From 5f138cf85af05b6375d2fa50d1b96bfa1f2311a8 Mon Sep 17 00:00:00 2001 From: Nathan Hartman <hartman.nat...@gmail.com> Date: Thu, 2 Jan 2020 12:13:21 -0500 Subject: [PATCH] Fix warning: implicit declaration of nxsem_post() icmp/icmp_netpoll.c: Fix compile warning regarding implicit declaration of function nxsem_post(). This appeared after include of nuttx/kmalloc.h was removed recently. --- net/icmp/icmp_netpoll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/icmp/icmp_netpoll.c b/net/icmp/icmp_netpoll.c index 99b299db90..2981891e4d 100644 --- a/net/icmp/icmp_netpoll.c +++ b/net/icmp/icmp_netpoll.c @@ -43,6 +43,7 @@ #include <poll.h> #include <debug.h> +#include <nuttx/semaphore.h> #include <nuttx/net/net.h> #include "devif/devif.h" -- 2.20.1
From 4c8a63575194e5ab51b89d59e36f98b65fb53ccb Mon Sep 17 00:00:00 2001 From: Nathan Hartman <hartman.nat...@gmail.com> Date: Thu, 2 Jan 2020 12:25:58 -0500 Subject: [PATCH] Fix uninitialized 'ret' in icmp_pollsetup() icmp/icmp_netpoll.c: Fix return of uninitialized 'ret' when no error occurs. That is, on what should be a successful return from this function, an uninitialized value was returned, which may indicate an undeserved error. --- net/icmp/icmp_netpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/icmp/icmp_netpoll.c b/net/icmp/icmp_netpoll.c index 99b299db90..be1518ac4e 100644 --- a/net/icmp/icmp_netpoll.c +++ b/net/icmp/icmp_netpoll.c @@ -158,7 +158,7 @@ int icmp_pollsetup(FAR struct socket *psock, FAR struct pollfd *fds) FAR struct icmp_conn_s *conn = psock->s_conn; FAR struct icmp_poll_s *info; FAR struct devif_callback_s *cb; - int ret; + int ret = OK; DEBUGASSERT(conn != NULL && fds != NULL); -- 2.20.1
