Hi Anjana,

Your patch was generated incorrectly, it doesn't apply.

You can test it yourself to confirm it doesn't work:

Clone a pristine incubator-nuttx from github, enter inside it and run:

$ patch -p1 --dry-run < /tmp/RX65N_arch.txt

You will see many Hunk #xxx FAILED ...:

172 out of 172 hunks FAILED
The next patch would create the file arch/renesas/src/.gitignore

Please fork the apache incubator-nuttx in github and work with it,
then you can submit a PR (Pull Request) from github directly if you
prefer.

I noticed you used "diff -Naur" to compare two different repositories,
however I noticed an interesting thing:

diff -Naur nuttx-8.2_apache_202001101453/arch/renesas/include/rx65n/iodefine.h
incubator-nuttx-master/arch/renesas/include/rx65n/iodefine.h
--- nuttx-8.2_apache_202001101453/arch/renesas/include/rx65n/iodefine.h
2019-12-20 10:27:18.000000000 +0530
+++ incubator-nuttx-master/arch/renesas/include/rx65n/iodefine.h
 2020-01-10 02:52:48.000000000 +0530
@@ -907,61 +907,20 @@
 #define  _CLR( x )              __CLR( x )
 #define   CLR( x , y )  _CLR( _ ## x ## _ ## y )

-#define BSC     (*(volatile struct st_bsc      *)0x81300)
-#define CAC     (*(volatile struct st_cac      *)0x8b000)
-#define CAN0    (*(volatile struct st_can      *)0x90200)
-#define CAN1    (*(volatile struct st_can      *)0x91200)
-#define CMT     (*(volatile struct st_cmt      *)0x88000)
+#define BSC     (*(volatile struct st_bsc      *)0x81300)
+#define CAC     (*(volatile struct st_cac      *)0x8b000)
+#define CMT     (*(volatile struct st_cmt      *)0x88000)

But, if you loop the apache incubator-nuttx file
arch/renesas/include/rx65n/iodefine.h at github you will see:

#define BSC             (*(volatile struct st_bsc      *)0x81300)
#define CAC             (*(volatile struct st_cac      *)0x8b000)
#define CMT             (*(volatile struct st_cmt      *)0x88000)
#define CMT0    (*(volatile struct st_cmt0     *)0x88002)
#define CMT1    (*(volatile struct st_cmt0     *)0x88008)
#define CMT2    (*(volatile struct st_cmt0     *)0x88012)
#define CMT3    (*(volatile struct st_cmt0     *)0x88018)

Note that after BSC there are too much space characters that don't
exist at your incubator-nuttx-master, maybe because you or someone
else already modified it.

Also note that the current file in github already has the definitions
sequence your patch was trying to create: (BSC, CAC, CMT, ...), but in
github it is incorrectly formatted (wrong spaces).

Please review everything carefully, run nxstyle and before submitting
a patch or PR verify if the generated diff files are correct.

BR,

Alan

On 1/14/20, Anjana <anj...@tataelxsi.co.in.invalid> wrote:
> Hi All,
>
> We have uploaded patch for arch/renesas & boards/.
>
> The patch is created for the code version dated 08th Jan 2020 (Downloaded on
> 08th Jan 2020).
>
> This patch adds support for the following :
>
>
>   1.  Added Support for RTC driver in RX65N
>   2.  Added support for IPV6.
>
>
> Regards,
>
> Anjana
>
> ________________________________
> Disclaimer: This email and any files transmitted with it are confidential
> and intended solely for the use of the individual or entity to whom they are
> addressed. If you are not the intended recipient of this message , or if
> this message has been addressed to you in error, please immediately alert
> the sender by reply email and then delete this message and any attachments.
> If you are not the intended recipient, you are hereby notified that any use,
> dissemination, copying, or storage of this message or its attachments is
> strictly prohibited. Email transmission cannot be guaranteed to be secure or
> error-free, as information could be intercepted, corrupted, lost, destroyed,
> arrive late or incomplete, or contain viruses. The sender, therefore, does
> not accept liability for any errors, omissions or contaminations in the
> contents of this message which might have occurred as a result of email
> transmission. If verification is required, please request for a hard-copy
> version.
> ________________________________
>

Reply via email to