Hi,

> So what you suggest it that we as committer don't need disscuss
> anything with the contributor, we just need take his PR and do what we
> think the right modification then merge directly.

You could either discuss it with them or accept the PR and improve it. What you 
do may be decided on a case by case basis and how much work it needs, it it’s 
just a minor fix I would suggest accepting it and fixing the issue right away. 
If it requires a lot of changes have a discussion with them so their next PR is 
better.

> I talk this example just because I saw some people send a PR and then
> forget it in other github project, the contributor has to correct the
> issue in PR by self sometime.

It’s not the responsibility of the contributor to correct all issues, it up the 
the PPMC as their primary goal is to grow the community and make their project 
welcoming not work on the code. All contribution are generally valuable even if 
they need some minor tweaks and you want to encourage people to contribute. 
Apache often says "community over code”.

Thanks,
Justin

Reply via email to