Yeah I thought about the too.... But think of the can of worm on the commit history: Every PR touches the cfg file.
Rebase HELL! Yuch! Fix or replace the tool! -----Original Message----- From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com] Sent: Sunday, March 15, 2020 6:08 AM To: dev@nuttx.apache.org Subject: Re: Should we relax precheck a little bit? How about we put this special treatment to another file(e.g. nxstyle.cfg)? So we don't pollute the source code. On Sun, Mar 15, 2020 at 7:47 PM Schock, Johannes - NIVUS GmbH <johannes.sch...@nivus.com> wrote: > > Hello, > I filed a pull request that introduces an idea of controlling the > behaviour of nxstyle from inside the file under test. > https://github.com/apache/incubator-nuttx/pull/569 > This would allow to address some special requirements that are needed in > cornercases (e.g. whitelisting), and, by using the ignore feature, to > switch of testing for ranges of the file that are correct but nxstyle > isn't happy about it (yet unaddressed cornercases). > This would give a contributor/commiter the possibility to explicitly pass > the PR through the style check, and perhaps file an nxstyle issue. > From time to time we could grep for the ignore command and remove it if > the issue had been resolved. > Please share your thoughts. > Johannes > > P.S.: if some aren't happy with the xml-like syntax, we can change this > for sure
