Maybe because you sent it as .patch, you need to rename it to .txt. This is an old issue we still facing...
On 5/14/20, Joao Matos <j...@tritao.eu> wrote: > Sorry for the late reply. > > Dunno why the patches are not showing up, they show up as attached on my > email client. > > Here goes in Gist format: > https://gist.github.com/tritao/406dc1460a9df6788ce2823d300be7a7 > > On Tue, May 5, 2020 at 4:09 PM Rob Voisey <r...@fenconsultants.com> wrote: > >> Actually it was my fault, I'm on a slightly old build and although I'd >> diffed stm32_qspi.c against the head I'd missed an actual fix amongst all >> the formatting corrections. I did a more thorough job this time and my >> MX23L51245G driver now appears to read, write and erase correctly. >> >> I'm still interested in João's patches in case there are other issues I >> haven't run into yet. >> >> Cheers >> >> Rob >> >> On Tue, 5 May 2020 at 13:33, Rob Voisey <r...@fenconsultants.com> wrote: >> >> > Hi João, >> > >> > Thanks, I'd love to get those patches if you could email or commit >> > them. >> > >> > Right now, using the MTD interface, I can read blocks of data but I >> > can't >> > erase them because that uses a non-data command and those never set TCF >> for >> > reasons I've yet to understand. >> > >> > Rob >> > >> > On Tue, 5 May 2020 at 13:11, Joao Matos <j...@tritao.eu> wrote: >> > >> >> Hello Rob, >> >> >> >> We have been using the STM32 F7 QSPI code, and found out the same >> issues. >> >> >> >> I've attached some patches with the fixes we have made, hope that >> >> helps. >> >> >> >> >> >> >> >> On Mon, May 4, 2020 at 7:18 PM Rob Voisey <r...@fenconsultants.com> >> wrote: >> >> >> >>> Thanks Alan. I see it's almost an identical driver so I'll see if I >> >>> can >> >>> get >> >>> hold of an L4 board. >> >>> >> >>> Rob >> >>> >> >>> >> >>> On Mon, 4 May 2020 at 19:05, Alan Carvalho de Assis >> >>> <acas...@gmail.com >> > >> >>> wrote: >> >>> >> >>> > Hi Rob, >> >>> > >> >>> > There are some QSPI usage examples for STM32L4 that is very similar >> >>> > and you can use as starting point. >> >>> > >> >>> > BR, >> >>> > >> >>> > Alan >> >>> > >> >>> > On 5/4/20, Rob Voisey <r...@fenconsultants.com> wrote: >> >>> > > Hi >> >>> > > >> >>> > > I haven't been able to find any code that uses the STM32F7 QSPI >> code >> >>> even >> >>> > > though it has been in the codebase for a few years. An example >> >>> candidate >> >>> > > would be the STM32F769I-DISC0 board which has an MX25L51245G >> >>> > > flash >> >>> device >> >>> > > on that bus. It's also the combination that I need to get working >> >>> for my >> >>> > > board. >> >>> > > >> >>> > > To that end I wrote a driver for the MX25L51245G forked from the >> >>> existing >> >>> > > MX25RXX driver, and I'm having some trouble getting non-data >> >>> commands to >> >>> > > complete. The RDID command works fine but non-data commands hang >> >>> > > in >> >>> the >> >>> > > QSPI driver waiting on transfer complete status. I've spent a few >> >>> hours >> >>> > > poking around but to narrow it down I was wondering if anyone >> >>> > > knows >> >>> the >> >>> > > status of the F7 QSPI driver? Is it up to date and tested? Is >> >>> > > there >> >>> any >> >>> > > code that uses it? I'd love to have a known good starting point. >> >>> > > >> >>> > > Cheers >> >>> > > >> >>> > > Rob >> >>> > > >> >>> > >> >>> >> >> >> >
