Hi Michal,

I think that we should unify the compatible code so that we reduce the 
maintenance and avoid having diverging functionality and bugfixes 

Regards
Alin


-----Original Message-----
From: Michal Lenc <michall...@seznam.cz> 
Sent: den 30 augusti 2021 10:21
To: dev@nuttx.apache.org
Subject: Possibility of merging few lcd drivers into one file


Hi all,




I was taking a look into the current state of files for LCD drivers
(drivers/lcd/) and I am wondering about your opinion about this. Is there any 
particulal reason not to merge few of those drivers into one file? I am talking 
mostly about merging files st7735.c, st7789.c and st7796.c (not merged into 
mainline yet, just in my repo) into file st77xx.c (and do the same with header 
files). It still could be configurable in menuconfig separately as ST7735 or 
ST7789, but source codes would be in one file. It should not be that hard to 
change this as st7789.c and st7796 are mostly copies of st7735.c. Perhaps 
drivers for ST7565 and ST7567 could be also merged into ST75XX, but that would 
take more job as the source codes seems to be different. Thanks


Best regards,
Michal Lenc

Reply via email to