Hi Jukka, I think everybody want RISC-V with Kernel mode support on NuttX.
Sometimes we get really angry because some comments seem too picky, but we need to believe in the "The Wisdom of Crowds" (i.e.: https://www.youtube.com/watch?v=Qfh-k9P8ZPI ) So, instead getting mad about it, please try to implement the suggestions. You are an experienced contributor and I'm sure you can get this PR accepted as well. :-) BR, Alan On 4/1/22, Jukka Laitinen <jukka.laiti...@iki.fi> wrote: > > > Hi, > > If RISC-V S-mode and CONFIG_BUILD_KERNEL support is not wanted into NuttX, > please say it out loud instead of playing unfair review games. > > The team has better things to do than re-write code letter-by letter via > code review, week after week. The code is good quality and working, and is > done according to nuttx standards. > > We have always the option to keep it all ourselves and branch off. We do > want to contribute, but if there is no will to receive code, we can change > the policy and just bring in small bugfixes in the future and let the > fundamental larger improvements stay in our own repositories. > > If you want to prettify things to look better to your eye, just make another > PR *yourself* *after* merging the working, well inspected and approved PR. > > Thanks for your input for this issue, > Jukka >
