On Wed, Jul 20, 2022 at 10:09 AM Karel Kočí <cyn...@email.cz> wrote: > I discovered that commit 664d45dcbace03a879017aa99566592be31f4308 broke LCD > framebuffer (at least for ST7789). The issue is with `putarea` call. > Originally > it was called only when full display redraw was requested but now it is called > every time when defined. The core of the issue is that from documentation the > buffer passed to the putarea should contain pixels for that area but LCD > framebuffer always passes the complete buffer. > > I see two possible fixes. Either we call putarea only when full display update > is requested or we change the definition of the putarea in such a way that it > is > driver's resposibility to pick the are from buffer. The first solution is > simple > and is pretty much revert to the previous state. The second change is kind of > what is suggested in the new comment added in > 664d45dcbace03a879017aa99566592be31f4308 but no work was done to propagate > that > to actuall API documentation in 'include/nuttx/lcd/lcd.h' 😡. > > Thus, what do you think? Revert or propagation of the new behavior?
For reference, this is PR #6551. I added a comment to it linking to this email thread... Nathan
