> There used to be one defining inline to be nothing for ZDS-II . It would > > only be necessary to restore it for ZDS-II. This does not fix the > function > > duplication of static inline functions in header files, however. > > Is the duplication really a problem, though? > > After all, the whole point of a static inline function is to insert > the code directly at the call sites, which implies duplication and > larger code footprint. Ostensibly static inline should only be used > for "very small" functions. >
It can be and was in the past. It depends not only on the size of the static inline function but also on how many are in a header file and how many times the header file is included. There are 15 in ctype.h. I removed most of the others a couple of years ago (replacing them with macros)still , but we grew more since that PR. But I think that the situation is not so bad now. Another problem (for SDCC only) is this: https://acassis.wordpress.com/2022/01/14/testing-nuttx-rtos-on-z80-simulator/
