Hi Tim,
I usually do the following steps:
- compile locally the patch and test it
- run nxstyle to ensure that there are no errors
- let the CI run and fix errors
- wait for others to review and comment
Best regards
Alin
-----Original Message-----
From: Tim Hardisty <t...@jti.uk.com.INVALID>
Sent: den 16 november 2022 11:58
To: dev@nuttx.apache.org
Subject: Re: Will a PR be ignored if it fails checks?
Hi Alin,
Ok - will do.
I ran the checkpatch script as per guides - should I have done something else
as well before submitting a PR?
Thanks,
Tim.
On 16/11/2022, 08:00, "alin.jerpe...@sony.com" <alin.jerpe...@sony.com> wrote:
Hi Tim,
Please fix the warning / error without waiting for someone to review it.
Best regards
Alin
-----Original Message-----
From: Tim Hardisty <t...@jti.uk.com.INVALID>
Sent: den 15 november 2022 20:25
To: dev@nuttx.apache.org
Subject: Will a PR be ignored if it fails checks?
As subject really. My (first real) PR failed some checks due to an unused
variable. An easy fix, but I wanted to wait for any other feedback before
resubmitting....but not much point waiting if the fail will mean no one reviews
it lol.
What's the process?
