Hi Tim, I usually do the following steps: - compile locally the patch and test it - run nxstyle to ensure that there are no errors - let the CI run and fix errors - wait for others to review and comment
Best regards Alin -----Original Message----- From: Tim Hardisty <[email protected]> Sent: den 16 november 2022 11:58 To: [email protected] Subject: Re: Will a PR be ignored if it fails checks? Hi Alin, Ok - will do. I ran the checkpatch script as per guides - should I have done something else as well before submitting a PR? Thanks, Tim. On 16/11/2022, 08:00, "[email protected]" <[email protected]> wrote: Hi Tim, Please fix the warning / error without waiting for someone to review it. Best regards Alin -----Original Message----- From: Tim Hardisty <[email protected]> Sent: den 15 november 2022 20:25 To: [email protected] Subject: Will a PR be ignored if it fails checks? As subject really. My (first real) PR failed some checks due to an unused variable. An easy fix, but I wanted to wait for any other feedback before resubmitting....but not much point waiting if the fail will mean no one reviews it lol. What's the process?
