Many people are affected by this double echo

https://github.com/apache/nuttx/issues/8731

Sebastien


Le 07/03/2023 à 17:09, Gregory Nutt a écrit :
I imagine that this is occurring because readline also echos the input:

https://github.com/apache/nuttx-apps/blob/master/system/readline/readline_common.c#L644

The low-level serial driver should not echo just because /isconsole /is true.  Console echo is always handled by the application.  I would say that that is a bug.

On 3/7/2023 9:45 AM, Sebastien Lorquet wrote:
Hi,

I am connecting to my board using

python3 -m serial --raw --eol cr /dev/ttyUSB0 115200

This has ALWAYS worked.

Today it does not work anymore.

Every character I send to NSH is echoed TWICE, see below just typing help:

----------------------------------

seb@lap:~$ python3 -m serial --raw /dev/ttyUSB0 115200
--- Miniterm on /dev/ttyUSB0  115200,8,N,1 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
hheellpp

help usage:  help [-v] [<cmd>]

----------------------------------

Only the echo is double, normal output is OK and characters are only inputed once

Miniterm is not doing any echo. This worked fine before.


I have found that this commit is the problem

https://github.com/apache/nuttx/commit/68384e9db42e254b2cf6720bc3380aebdd2b298c

Reverting this fixes the dual echo.


I dont know what dev->isconsole does but

Just HOW can such a general breakage be missed by the super duper cool testing that takes hours to complete?


Please STOP breaking NuttX, AGAIN

This is a lot of issues for a single day work.


Thank you

Sebatien


Reply via email to