Hi Saurav, Thank you for looking at our code base and planning to add Documentation, that is really important!
NuttX has a long history but our Documentation is still lagging behind, so your work will be very beneficial for our community. I took a look at that macro you asked and seems it was wrote by Greg almost 16 years ago: 08d439fefbd (patacongo 2008-08-02 14:44:25 +0000 262) #define DIRSEC_NDXMASK(f) (((f)->fs_hwsectorsize - 1) >> 5) BTW, why do you think it is wrong, could you please share your thoughts? Best Regards, Alan On Fri, Feb 2, 2024 at 3:50 AM Saurav Pal <resyfer....@gmail.com> wrote: > Hi, > > I was browsing through the source code of FAT implementation, trying to > write some documentation, and I came across this macro > <https://github.com/apache/nuttx/blob/master/fs/fat/fs_fat32.h#L264>. > > Since I'm new to the codebase, I wanted to know if this (especially > DIRSEC_NDXMASK(fs)) is correct and I'm missing something or if it should > have been DIRSEC_NDXMASK(f) (and I can raise an issue for it). > > Thanks and regards, > Saurav >
