Nathan, Absolutely! I'm talking with him and he already spotted many issues. Other issues we all faced and we didn't care, like enabling DHCPC and the Kconfig didn't enable DNSCLIENT). Although we know that in theory people could use DHCPC without DNS, in common usage it will not happen.
He also pointed out something we never thought was an issue: he enabled DHCPC and didn't get the dhcpclient command in the shell. Why are we using "renew" name? It is not used on Linux or BSD! Maybe we should rename it to something that end users will recognize easily from Linux. I think it is important to listen to our users, this feedback is very useful to help us to improve our system. Best Regards, Alan On Thu, Jul 4, 2024 at 11:51 PM Nathan Hartman <hartman.nat...@gmail.com> wrote: > On Thu, Jul 4, 2024 at 7:19 PM Gregory Nutt <spudan...@gmail.com> wrote: > > > > > On 7/4/2024 4:44 PM, Alan C. Assis wrote: > > > I think Greg avoided using submodules because there are many issues > > caused > > > by it. > > > > > > In fact submodules could avoid this issue, but maybe we could have some > > > marks indicating the last commit expected on apps/ to the current > nuttx/ > > > > > > This way if someone git pull the nuttx/ and forgot to git pull the > apps/ > > > the make will detect it and will ask the user to do it. > > > > > > I don't like this approach because it makes things more rigid > > (inflexible). > > > This is not something easy to fix. > > > > > > BR, > > > > > > Alan > > > > That coupling could cause problems with the separation of OS and > > applications. We've done a lot of effort to assure that the apps are > > totally independent of the OS and totally optional. > > > > In the past, apps, Documentation, boards, and arch were all submodules. > > Users hated the use of submodules and I would be hesitant to ever force > > that on users again. It really complicates and slows down progress when > > you don't know if a change is in the currently selected submodule or > > not. It basically requires a PR and merge or more per day to be usable. > > > > > > > > It sounds like submodules are a bad idea... ok, scratch that idea. > > In the blog he said he didn't want a shell & etc so it sounds like he > doesn't know that he can have his own apps repo, or use our apps repo but > disable NSH and use his own program as the initial task. Also since he had > trouble with debugging on FreeRTOS we should point out that the NSH shell > and various builtins (if you enable these features) can be very useful for > interactively debugging your board. > > All in all a good blog post and I think good feedback for us. We should > improve distclean (maybe force it to actually distclean no matter what the > current state is on disk) and we should improve documentation, especially > to teach what kinds of things you can interactively test with a shell, and > then disable the shell when no longer needed. > > Cheers, > Nathan >
