Yes Sebastien, its a mess, I can see it crystal clear now, code base is not a pigsty for untested ideas, this needs to stop, thanks for sounding the alarm!
I am just sad that Greg left because of that, I understand it now :-( GitHub is not important for me, its a tool that we use for code review, like a car you use to travel, and you are not there to help us stop this mess :-( Tomek On Tue, Feb 4, 2025 at 10:50 AM Sebastien Lorquet <sebast...@lorquet.fr> wrote: > > I dont have a github account, this website looks like it is very > important for you. you keep mentioning it at every occasion. > > linkage of nuttx and apps repo is a problem and I think more efforts > should be made to decouple it even more. > > Otherwise you cant really tell anyone that they can have their own apps. > > > line max is solved by incremental updates to avoid other breakages. > > next issue is some build system incompatibility that messes up libboard.a > > my board is a custom stm32f4 board and I recently had the surprise to > learn that it's still probably linked in the board/arm/stm32/common > stuff, or not anymore, no idea why and how. > > Looks like 6 months ago, the board was built using a > board/src/Make.defs, so I removed the board/src/Makefile > > And now it looks like that I need it again. > > > CC: builtin.c > arm-none-eabi-gcc -c -Wstrict-prototypes -Wno-attributes > -Wno-unknown-pragmas -Wno-psabi -fomit-frame-pointer -fno-common -Wall > -Wshadow -Wundef -ffunction-sections -fdata-sections "-g" > -mlittle-endian -march=a > rmv7e-m -mtune=cortex-m4 -mfloat-abi=soft -mthumb -Wa,-mthumb > -Wa,-mimplicit-it=always -isystem > /home/slo/Sources/ccv5-env/nuttx/include -D__NuttX__ -DNDEBUG > -D__KERNEL__ -I /home/slo/Sources/ccv5-env/nuttx/sc > hed builtin.c -o builtin.o > arm-none-eabi-ar rcs libbinfmt.a binfmt_globals.o > binfmt_initialize.o binfmt_register.o binfmt_unregister.o > binfmt_loadmodule.o binfmt_unloadmodule.o binfmt_execmodule.o > binfmt_exec.o binfmt_copyargv.o binf > mt_copyactions.o binfmt_dumpmodule.o builtin.o > make[1]: Leaving directory '/home/slo/Sources/product-env/nuttx/binfmt' > IN: binfmt/libbinfmt.a -> staging/libbinfmt.a > install -m 0644 binfmt/libbinfmt.a staging/libbinfmt.a > make -C arch/arm/src EXTRA_OBJS="" LINKLIBS="libsched.a libdrivers.a > libboards.a libc.a libmm.a libarch.a libapps.a libnet.a libfs.a > libbinfmt.a" APPDIR="/home/slo/Sources/product-env/ccv5/apps" > EXTRAFLAGS="-D__KE > RNEL__ " nuttx > make[1]: Entering directory > '/home/slo/Sources/product-env/nuttx/arch/arm/src' > make -C board libboard.a EXTRAFLAGS="-D__KERNEL__ " > make[2]: Entering directory > '/home/slo/Sources/product-env/product/board/src' > make[2]: *** No rule to make target 'libboard.a'. Stop. > make[2]: Leaving directory > '/home/slo/Sources/product-env/product/board/src' > make[1]: *** [Makefile:184: board/libboard.a] Error 2 > make[1]: Leaving directory > '/home/slo/Sources/product-env/nuttx/arch/arm/src' > make: *** [tools/Unix.mk:552: nuttx] Error 2 > > > Sebastien > > > On 31/01/2025 20:24, Tomek CEDRO wrote: > > On Fri, Jan 31, 2025 at 6:01 PM Sebastien Lorquet<sebast...@lorquet.fr> > > wrote: > >> hello > >> you are right, let's try: > >> 12.8.0 -> configure broken > >> 12.7.0 -> configure works > >> > >> apps is copied from master. > >> > >> CC: nsh_alias.c > >> In file included from nsh_alias.c:39: > >> nsh_console.h:191:18:error: 'LINE_MAX' undeclared here (not in a > >> function); did you mean 'LINK_MAX'? > >> 191 | char cn_line[LINE_MAX]; > >> | ^~~~~~~~ > >> | LINK_MAX > >> > >> OK so I cant use master apps > > This change comes from aligning to POSIX LINE_MAX. It was done in few steps. > > > > Are you sure that nuttx and nuttx-apps are in sync? If not then I > > cannot help. If yes, please report a bug report on GitHub, and ask for > > 12.8.1 patch release when fix is ready if really necessary. > > -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
