Hi,
Thanks for the call.
The change looks reasonable as far as I am concerned.
It looks like it increases memory usage a little bit, but it's not dramatic.
I dont know if we have policies regarding memory usage statistics.
Micropython is quite strict about this.
Someone should double-check the semaphore game. I see an additional
nxsem_post with no obviously visible companion. Might be ok but I didnt
check.
Is this comment still relevant?
https://github.com/apache/nuttx/pull/15809/commits/eacf777a265c2eafd9b297a9a062ec64a747c19d#diff-390ca31ed49a4cbf121df64d1aced6151820010c51fd87ab070f8d98b96493cdR1023
Since there is now one poll structure per reader there is no need to
find an available slot?
Sebastien
On 11/02/2025 17:37, Alan C. Assis wrote:
Could someone using CAN Bus review this modification:
https://github.com/apache/nuttx/pull/15809
BR,
Alan
