On Wed, Feb 12, 2025 at 11:37 AM Tomek CEDRO <to...@cedro.info> wrote: > 18. Pull Requests should be as small as possible and focused on only > one functional change. Different functional changes should be provided > in separate Pull Requests. Remember that breaking changes are not > welcome. Pull Requests must not break overall build, runtime, and > compatibility, especially for other components. When changes must be > bundled together in order to maintain functionality and > self-compatibility, exception can be made, and this must be clearly > stated there is no other way.
+1: New authors sometimes provide single PR with different functional changes, that should split into different PRs, this should keep things clean. Sometimes big PR is required to update single area (i.e. chip drivers) then with good argumentation this should be acceptable. > 19. "Lazy consensus" is a situation where PR is auto-merged into the > upstream when not enough reviews are done in predefined time (i.e. > there are no minimum required positive reviews within two weeks time). > PR should initially be treated according the general rules (4 > independent reviewers); After a week without enough reviewers, a call > should be made on the > mailing list, explaining why the PR can't be split into smaller PRs; > After two weeks without any reviewers, we could merge if the above > conditions are met and we have at least one independent reviewer. This > may solve situation when we don't have enough people to review it (or > we are not interested in that). It prevents people from forking the > project just to be able to develop their stuff: *we* *really would not > like that*. The PR's author is still responsible for fixing some > bugs if found in the future. -1: Strong -1 here because it is safer not to merge invalid code than to deal with breaks and complains after "lazy" merge. Quality requires time. It should not be a big problem to ask for discussion on mailing list, or request additional reviews on github. Otherwise we could just merge stalled PRs and nothing will work anymore :-P -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
