Hi,

thanks for the explanation

For the future please mark this kind of commits so that they are included
We will see if there are other -1 ans add it to RC1

Thanks for testing and reporting the issue

On Tue, 8 Apr 2025, 20:10 Tiago Medicci Serrano, <tiago.medi...@gmail.com>
wrote:

> Yes, but there are coupled changes: this commit
> <
> https://github.com/apache/nuttx/commit/b388b84af68f2c602f74f65f7161325d8c419527
> >
> changed
> the SPI flash frequency for ESP32-H2 (it doesn't support 48MHz, but it must
> be flashed at this speed). However, for MCUboot, it relies on
> `CONFIG_ESPTOOLPY_FLASHFREQ` macro, which was introduced (set to 48MHz)
> only in #16131 <https://github.com/apache/nuttx/pull/16131>. My fault for
> not finding out that both were somehow coupled.
>
> The CI doesn't build the bootloader (MCUboot), so that's why the CI didn't
> fail. But, if you use MCUboot (and call `make bootloader`
> <
> https://nuttx.apache.org/docs/latest/platforms/risc-v/esp32h2/index.html#bootloader-and-partitions
> >),
> the build will fail.
>
> Em ter., 8 de abr. de 2025 às 14:55, Alin Jerpelea <jerpe...@gmail.com>
> escreveu:
>
> > the spi flas selection is not a fix but a feature!
> >
> > On Tue, 8 Apr 2025, 18:37 Tiago Medicci Serrano, <
> tiago.medi...@gmail.com>
> > wrote:
> >
> > > -1.
> > >
> > > Unfortunately, `esp32h2-devkit:mcuboot_nsh` is broken. To build the
> > MCUboot
> > > bootloader, the following PR is required:
> > > https://github.com/apache/nuttx/pull/16131
> > >
> > > Em ter., 8 de abr. de 2025 às 03:41, Lee, Lup Yuen <lu...@appkaki.com>
> > > escreveu:
> > >
> > > > +1 for Milk-V Duo S, Ox64, Star64 and PinePhone
> > > >
> > > > ===== Milk-V Duo S Compiler
> > > > + riscv-none-elf-gcc -v
> > > > Using built-in specs.
> > > > COLLECT_GCC=riscv-none-elf-gcc
> > > >
> > > >
> > >
> >
> COLLECT_LTO_WRAPPER=/Users/luppy/xpack-riscv-none-elf-gcc-13.2.0-2/bin/../libexec/gcc/riscv-none-elf/13.2.0/lto-wrapper
> > > > Target: riscv-none-elf
> > > > Configured with:
> > > >
> > > >
> > >
> >
> /Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/sources/gcc-13.2.0/configure
> > > >
> > > >
> > >
> >
> --prefix=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/application
> > > >
> > > >
> > >
> >
> --with-sysroot=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/application/riscv-none-elf
> > > > --with-native-system-header-dir=/include
> > > >
> > > >
> > >
> >
> --infodir=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/aarch64-apple-darwin20.6.0/install/share/info
> > > >
> > > >
> > >
> >
> --mandir=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/aarch64-apple-darwin20.6.0/install/share/man
> > > >
> > > >
> > >
> >
> --htmldir=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/aarch64-apple-darwin20.6.0/install/share/html
> > > >
> > > >
> > >
> >
> --pdfdir=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/aarch64-apple-darwin20.6.0/install/share/pdf
> > > > --build=aarch64-apple-darwin20.6.0 --host=aarch64-apple-darwin20.6.0
> > > > --target=riscv-none-elf --disable-libgomp --disable-libmudflap
> > > > --disable-libquadmath --disable-libsanitizer --disable-libssp
> > > --disable-nls
> > > > --disable-shared --disable-threads --disable-tls
> > > --enable-checking=release
> > > > --enable-languages=c,c++,fortran
> > > >
> > > >
> > >
> >
> --with-gmp=/Users/ilg/actions-runners/xpack-dev-tools/_work/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/darwin-arm64/aarch64-apple-darwin20.6.0/install
> > > > --with-newlib --with-pkgversion='xPack GNU RISC-V Embedded GCC arm64'
> > > > --with-gnu-as --with-gnu-ld --with-system-zlib --with-abi=ilp32
> > > > --with-arch=rv32imac --enable-multilib
> > > > Thread model: single
> > > > Supported LTO compression algorithms: zlib zstd
> > > > gcc version 13.2.0 (xPack GNU RISC-V Embedded GCC arm64)
> > > >
> > > > ===== Milk-V Duo S Configuration
> > > > + ./tools/configure.sh milkv_duos:nsh
> > > >
> > > > ===== Milk-V Duo S Size
> > > > + riscv-none-elf-size nuttx
> > > >    text   data    bss    dec    hex filename
> > > >  160887   1545  30224 192656  2f090 nuttx
> > > >
> > > > ===== Milk-V Duo S NSH Info and Free
> > > > NuttShell (NSH) NuttX-12.9.0
> > > > nsh> uname -a
> > > > NuttX 12.9.0 47cdb6a283 Apr  8 2025 13:55:15 risc-v milkv_duos
> > > > nsh> free
> > > >       total       used       free    maxused    maxfree  nused  nfree
> > > name
> > > >     2061312      11624    2049688      33304    2048152     38      5
> > > Kmem
> > > >    20971520     720896   20250624              20250624
> > >  Page
> > > >
> > > > ===== Ox64 Compiler
> > > > + riscv-none-elf-gcc -v
> > > > Using built-in specs.
> > > > COLLECT_GCC=riscv-none-elf-gcc
> > > >
> > > >
> > >
> >
> COLLECT_LTO_WRAPPER=/home/luppy/xpack-riscv-none-elf-gcc-13.2.0-2/bin/../libexec/gcc/riscv-none-elf/13.2.0/lto-wrapper
> > > > Target: riscv-none-elf
> > > > Configured with:
> > > >
> > > >
> > >
> >
> /__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/sources/gcc-13.2.0/configure
> > > >
> > > >
> > >
> >
> --prefix=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/application
> > > >
> > > >
> > >
> >
> --with-sysroot=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/application/riscv-none-elf
> > > > --with-native-system-header-dir=/include
> > > >
> > > >
> > >
> >
> --infodir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/info
> > > >
> > > >
> > >
> >
> --mandir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/man
> > > >
> > > >
> > >
> >
> --htmldir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/html
> > > >
> > > >
> > >
> >
> --pdfdir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/pdf
> > > > --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
> > > > --target=riscv-none-elf --disable-libgomp --disable-libmudflap
> > > > --disable-libquadmath --disable-libsanitizer --disable-libssp
> > > --disable-nls
> > > > --disable-shared --disable-threads --disable-tls
> > > --enable-checking=release
> > > > --enable-languages=c,c++,fortran
> > > >
> > > >
> > >
> >
> --with-gmp=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install
> > > > --with-newlib --with-pkgversion='xPack GNU RISC-V Embedded GCC
> x86_64'
> > > > --with-gnu-as --with-gnu-ld --with-system-zlib --with-abi=ilp32
> > > > --with-arch=rv32imac --enable-multilib
> > > > Thread model: single
> > > > Supported LTO compression algorithms: zlib zstd
> > > > gcc version 13.2.0 (xPack GNU RISC-V Embedded GCC x86_64)
> > > > ===== Ox64 Configuration
> > > > + ./tools/configure.sh ox64:nsh
> > > >
> > > > ===== Ox64 Size
> > > > + riscv-none-elf-size nuttx
> > > >    text   data    bss    dec    hex filename
> > > >  164035   2313  33168 199516  30b5c nuttx
> > > >
> > > > ===== Ox64 NSH Info and Free
> > > > NuttShell (NSH) NuttX-12.9.0
> > > > nsh> uname -a
> > > > NuttX 12.9.0 47cdb6a283 Apr  8 2025 14:12:35 risc-v ox64
> > > > nsh> free
> > > >       total       used       free    maxused    maxfree  nused  nfree
> > > name
> > > >     2057216      11960    2045256      33608    2042800     42      5
> > > Kmem
> > > >    20971520     720896   20250624              20250624
> > >  Page
> > > >
> > > > ===== Star64 Compiler
> > > > + riscv-none-elf-gcc -v
> > > > Using built-in specs.
> > > > COLLECT_GCC=riscv-none-elf-gcc
> > > >
> > > >
> > >
> >
> COLLECT_LTO_WRAPPER=/home/luppy/xpack-riscv-none-elf-gcc-13.2.0-2/bin/../libexec/gcc/riscv-none-elf/13.2.0/lto-wrapper
> > > > Target: riscv-none-elf
> > > > Configured with:
> > > >
> > > >
> > >
> >
> /__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/sources/gcc-13.2.0/configure
> > > >
> > > >
> > >
> >
> --prefix=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/application
> > > >
> > > >
> > >
> >
> --with-sysroot=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/application/riscv-none-elf
> > > > --with-native-system-header-dir=/include
> > > >
> > > >
> > >
> >
> --infodir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/info
> > > >
> > > >
> > >
> >
> --mandir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/man
> > > >
> > > >
> > >
> >
> --htmldir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/html
> > > >
> > > >
> > >
> >
> --pdfdir=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install/share/pdf
> > > > --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
> > > > --target=riscv-none-elf --disable-libgomp --disable-libmudflap
> > > > --disable-libquadmath --disable-libsanitizer --disable-libssp
> > > --disable-nls
> > > > --disable-shared --disable-threads --disable-tls
> > > --enable-checking=release
> > > > --enable-languages=c,c++,fortran
> > > >
> > > >
> > >
> >
> --with-gmp=/__w/riscv-none-elf-gcc-xpack/riscv-none-elf-gcc-xpack/build/linux-x64/x86_64-pc-linux-gnu/install
> > > > --with-newlib --with-pkgversion='xPack GNU RISC-V Embedded GCC
> x86_64'
> > > > --with-gnu-as --with-gnu-ld --with-system-zlib --with-abi=ilp32
> > > > --with-arch=rv32imac --enable-multilib
> > > > Thread model: single
> > > > Supported LTO compression algorithms: zlib zstd
> > > > gcc version 13.2.0 (xPack GNU RISC-V Embedded GCC x86_64)
> > > >
> > > > ===== Star64 Configuration
> > > > + ./tools/configure.sh star64:nsh
> > > >
> > > > ===== Star64 Size
> > > > + riscv-none-elf-size nuttx
> > > >    text   data    bss    dec    hex filename
> > > >  159473   1545  27248 188266  2df6a nuttx
> > > >
> > > > ===== Star64 NSH Info and Free
> > > > NuttShell (NSH) NuttX-12.9.0
> > > > nsh> uname -a
> > > > NuttX 12.9.0 47cdb6a283 Apr  8 2025 14:27:11 risc-v star64
> > > > nsh> free
> > > >       total       used       free    maxused    maxfree  nused  nfree
> > > name
> > > >     2061312      11512    2049800      33200    2048184     36      6
> > > Kmem
> > > >    20971520     720896   20250624              20250624
> > >  Page
> > > >
> > > > ===== PinePhone Compiler
> > > > + aarch64-none-elf-gcc -v
> > > > Using built-in specs.
> > > > COLLECT_GCC=aarch64-none-elf-gcc
> > > >
> > > >
> > >
> >
> COLLECT_LTO_WRAPPER=/home/luppy/arm-gnu-toolchain-13.2.Rel1-x86_64-aarch64-none-elf/bin/../libexec/gcc/aarch64-none-elf/13.2.1/lto-wrapper
> > > > Target: aarch64-none-elf
> > > > Configured with:
> > > > /data/jenkins/workspace/GNU-toolchain/arm-13/src/gcc/configure
> > > > --target=aarch64-none-elf
> > > >
> > > >
> > >
> >
> --prefix=/data/jenkins/workspace/GNU-toolchain/arm-13/build-aarch64-none-elf/install
> > > >
> > > >
> > >
> >
> --with-gmp=/data/jenkins/workspace/GNU-toolchain/arm-13/build-aarch64-none-elf/host-tools
> > > >
> > > >
> > >
> >
> --with-mpfr=/data/jenkins/workspace/GNU-toolchain/arm-13/build-aarch64-none-elf/host-tools
> > > >
> > > >
> > >
> >
> --with-mpc=/data/jenkins/workspace/GNU-toolchain/arm-13/build-aarch64-none-elf/host-tools
> > > >
> > > >
> > >
> >
> --with-isl=/data/jenkins/workspace/GNU-toolchain/arm-13/build-aarch64-none-elf/host-tools
> > > > --disable-shared --disable-nls --disable-threads --disable-tls
> > > > --enable-checking=release --enable-languages=c,c++,fortran
> > --with-newlib
> > > > --with-gnu-as --with-headers=yes --with-gnu-ld
> > > > --with-native-system-header-dir=/include
> > > >
> > > >
> > >
> >
> --with-sysroot=/data/jenkins/workspace/GNU-toolchain/arm-13/build-aarch64-none-elf/install/aarch64-none-elf
> > > > --with-pkgversion='Arm GNU Toolchain 13.2.rel1 (Build arm-13.7)'
> > > > --with-bugurl=https://bugs.linaro.org/
> > > > Thread model: single
> > > > Supported LTO compression algorithms: zlib
> > > > gcc version 13.2.1 20231009 (Arm GNU Toolchain 13.2.rel1 (Build
> > > arm-13.7))
> > > >
> > > > ===== PinePhone Configuration
> > > > + ./tools/configure.sh pinephone:nsh
> > > >
> > > > ===== PinePhone Size
> > > > + aarch64-none-elf-size nuttx
> > > >    text   data    bss    dec    hex filename
> > > >  243754  14677  61078 319509  4e015 nuttx
> > > >
> > > > ===== PinePhone NSH Info and Free
> > > > NuttShell (NSH) NuttX-12.9.0
> > > > nsh> uname -a
> > > > NuttX 12.9.0 47cdb6a283 Apr  8 2025 14:18:23 arm64 pinephone
> > > > nsh> free
> > > >       total       used       free    maxused    maxfree  nused  nfree
> > > name
> > > >   133365760      22088  133343672      22768  133343632     24      2
> > > Umem
> > > >
> > > > Milk-V Duo S Log:
> > > > https://gist.github.com/lupyuen/bd046df427df0cc37a43e886c530af0e
> > > >
> > > > Ox64 Log:
> > > > https://gist.github.com/lupyuen/d94b9c12c6a5f9244462986af8a42116
> > > >
> > > > Star64 Log:
> > > > https://gist.github.com/lupyuen/636c5bb2a38c3a7898a0708a1fe4ff4c
> > > >
> > > > PinePhone Log:
> > > > https://gist.github.com/lupyuen/2d3cf48ec564dd7681f8cbda364004fd
> > > >
> > > > Lup
> > > >
> > > > On Tue, Apr 8, 2025 at 1:21 PM Alin Jerpelea <jerpe...@gmail.com>
> > wrote:
> > > >
> > > > > Hello all,
> > > > > Apache NuttX 12.9.0 RC0 has been staged under [1] and it's
> > > > > time to vote on accepting it for release. Voting will be open for
> > 72hr.
> > > > >
> > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1
> > are
> > > > > required to pass.
> > > > >
> > > > > The Apache requirements for approving a release can be found here
> [3]
> > > > > "Before voting +1 PMC members are required to download the signed
> > > > > source code package, compile it as provided, and test the resulting
> > > > > executable on their own platform, along with also verifying that
> the
> > > > > package meets the requirements of the ASF policy on releases."
> > > > >
> > > > > A document to walk through some of this process has been published
> on
> > > > > our project wiki and can be found here [4].
> > > > >
> > > > > [ ] +1 accept (indicate what you validated - e.g. performed the
> > non-RM
> > > > > items in [4])
> > > > > [ ] -1 reject (explanation required)
> > > > >
> > > > > Thank you all,
> > > > > Alin Jerpelea
> > > > >
> > > > > SCM Information:
> > > > >   Release tag: nuttx-12.9.0-RC0
> > > > >   Hash for the release nuttx tag:
> > > > 47cdb6a283974dd500f89c96e7ef8dc8abcca6c7
> > > > >   Hash for the release nuttx-apps tag:
> > > > > 036fe7668d81a02a9dc32cc18c31a8d74ee6fa4a
> > > > >
> > > > > [1] https://dist.apache.org/repos/dist/dev/nuttx/12.9.0-RC0/
> > > > > [2]
> > > > >
> > > > >
> > > >
> > >
> >
> https://raw.githubusercontent.com/apache/nuttx/nuttx-12.9.0-RC0/ReleaseNotes
> > > > > [3] https://www.apache.org/dev/release.html#approving-a-release
> > > > > [4]
> > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/NUTTX/Validating+a+staged+Release
> > > > >
> > > >
> > >
> >
>

Reply via email to