On Wed, Apr 16, 2025 at 1:25 AM Carlos Sanchez <carlossanc...@geotab.com.invalid> wrote:
> Related PR on the apps side, to make slcan work after the "bitrate no > longer brings interface up" change: > https://github.com/apache/nuttx-apps/pull/3059 > > While testing this, I think I have discovered a small mistake on my > previous, Nuttx-side PR, which slipped by me and by revision: "ret" > might be used uninitialized now because I removed the assignment on > stm32_fdcan_sock:1976 > > > https://github.com/apache/nuttx/pull/16199/files#diff-8efec4e19b7401adcc3961c078b98ab945ebcada8635105fb591d16cbd6e5210L1976 > > Should I make a mini PR for this? > > I was going to propose another global CAN change, removing the 1000 > factor from bitrate thus making bitrate calls use units in Hz instead > of kHz, so we can discuss that and (if agreed) I make the change on > the same PR to avoid creating so a tiny one. > What's the unit used on Linux? we need to align the interface with Linux. > > Thoughts? > > Carlos >
