Looks good and looks like it has been merged! Thank you Tomek for tackling this!!!
Cheers, Nathan On Tue, May 6, 2025 at 4:46 PM Tomek CEDRO <to...@cedro.info> wrote: > Thank you Nathan :-) > > I have talked with @Humbedooh on Slack, he said the config looks okay :-) > > I am not really sure about this "contexts" part, particularly the > exact naming convention in GitHub, so I am leaving this for now and > hope it wont break anything :-) > > contexts: > - Check > - Lint > - Build > > This means if Check, Lint, or Build fails then PR cannot be merged. > > Thank you :-) > Tomek > > On Tue, May 6, 2025 at 6:42 PM Nathan Hartman <hartman.nat...@gmail.com> > wrote: > > > > Hello Tomek :-) > > > > Thanks for doing that! > > > > I have found that the easiest/quickest way to talk to the Infra folks is > by > > Slack [1]. > > > > If you don't want to use Slack, you can write to Infra's users list (also > > see [1]). > > > > I recommend to try slack, but either way, give them the link to the PR > and > > ask nicely if they could verify it... > > > > [1] To contact Infra by Slack, see the section "Chat" at > > https://infra.apache.org/contact.html > > > > Hope that helps, > > Nathan > > > > On Tue, May 6, 2025 at 9:21 AM Tomek CEDRO <to...@cedro.info> wrote: > > > > > Hello world :-) > > > > > > I found a free moment to setup github master branch protections as > > > discussed before, for now PR is in Draft mode for careful review. Who > > > can we contact from Apache Admins to ask to verification? > > > > > > https://github.com/apache/nuttx/pull/16324 > > > > > > * We do not have "Settings" tab in the Apache's owned repository, thus > > > we need to update .asf.yaml file with repository settings. > > > * No direct push to master branch is possible. > > > * Require status checks to pass before merge. > > > * Setup reviews parameters. > > > * Require signatures. > > > * Require conversation resolution. > > > * Not sure if we want to enforce "linear history"? > > > * If all is fine here I will do the same update for nuttx-apps repo :-) > > > * I am not really familiar with all these settings, please review if > > > this is what we want/need. > > > * Particularly the "checks" needs verification if these are valid > > > names (@lupyuen?). > > > > > > Reference: https://github.com/apache/infrastructure-asfyaml. > > > > > > Thank you :-) > > > Tomek > > > > > > -- > > > CeDeROM, SQ7MHZ, http://www.tomek.cedro.info > > > > > > > -- > CeDeROM, SQ7MHZ, http://www.tomek.cedro.info >
