Re: RFC - AVR fixes and support for AVR DA/DB family

[kr . git]

Hi,















On 2025-05-14 12:26, Alan C. Assis wrote:

thanks for the patience, now it makes sense. I started with assumption that the default config file is created manually and then got confused by the "modifications to the installed .config" in the disclaimer (was thinking that is a step after I already have the default file complete and wasn't reading properly after that.) Anyway, version 3 of the patches is attached and also available in the Git repository as avrdx_fixes_v3. The difference from v2 is actually pretty minor. Advice from xiaoxiang781216 was spot on with regards to line number where the added line should go when editing manually. I reverted the manual change and configured it through kconfig-tweak/menuconfig/savedefconfig instead. The end result was identical to the manual edit for all AVR 8bit boards so files related to them did not change between v2 and v3 of the series. What did change is configurations for AVR 32bit - those chips are not affected by the original change altogether, there is no support for GCC and DEBUG_OPT_UNUSED_SECTIONS cannot be selected. I therefore reverted changes to related files (ie. default configurations and documentation.) Hope there are no more mistakes in the series. Please let me know if you find something else. On a side note - the pull request 16365 is mentioned in issue 16367 but the code linked in that issue doesn't seem to be anything AVR related.

Hi KR,


files, there is this disclaimer:

#
# This file is autogenerated: PLEASE DO NOT EDIT IT.
#

.config file.
# You can then do "make savedefconfig" to generate a new defconfig file
that includes your
# modifications.

You should modify options inside menuconfig, save it and create a new
defconfig, basically these are the steps you should follow:

$ ./tools/configure.sh boardname:profilename
$ make menuconfig
$ make savedefconfig
$ mv defconfig to boards/arch/chip/boardname/configs/profilename/

BR,

Alan

On Wed, May 14, 2025 at 6:20 AM <kr....@kerogit.eu> wrote:

Actually you shouldn't edit the Kconfig manually. Please see inside these # You can use "make menuconfig" to make any modifications to the installed

Hello,

thanks for letting me know and thanks to the people reviewing the PR.
Based on their feedback, I prepared version 2 of the patches:


and no developer experience. I did not know that the comment "#
CONFIG_SOMETHING is not set" will actually affect something, nor that
you are not supposed to set something to "no". The defconfig files are
now altered based on xiaoxiang781216's advice. I tested it again by

unselected after running tools/configure.sh and the interrupts vectors
were present in the built binary.

I also removed the comments from the defconfig files. Instead, the
notices are added into Documentation for every board that has a
directory there.

The patch that fixes missing dependency in Kconfig (0003) now also
removes brackets in the "depends on" clause based on xiaoxiang781216's

there.) Tested in menuconfig, it seems the dependency works correctly
this way.

There is an additional patch (0006) now too. I noticed that two files
added into Documentation by my previous patch series leaked into table

the documentation into HTML using make html and it seems to be correct
now.

Patches are available in avrdx_fixes_v2 and also attached.

Thanks again to everyone for the help.

On 2025-05-13 09:55, Alin Jerpelea wrote:
> The patches are submitted
> https://github.com/apache/nuttx/pull/16365
>
> Thanks for enhancing the AVR platform
>
> Best regards
> Alin
>

The elimination of unused sections patch (0004) was reworked. I have to admit that I only have user experience with Kconfig (Linux kernel build) building mega1284p-xplained:nsh and it worked correctly. The option was feedback. (There was no comment other than copy of the line in the patch without the brackets so I hope I correctly understood what was suggested of contents, one to the list of supported platforms, one to the list of supported AVR families. I created a subdirectory for both of those files and added link to them in respective index.rst files. Tested by building

0001-boards-avr-avrdx-breadxavr-replace-board-hello-confi.patch.gz
Description: application/gzip

0002-Documentation-platforms-avr-provide-more-information.patch.gz
Description: application/gzip

0003-boards-avr-avrdx-breadxavr-fix-dependency-in-Kconfig.patch.gz
Description: application/gzip

0004-arch-avr-reworked-eliminating-unused-sections-with-G.patch.gz
Description: application/gzip

0005-Documentation-platforms-avr-added-information-about-.patch.gz
Description: application/gzip

0006-Documentation-platforms-avr-move-documents-to-fix-ta.patch.gz
Description: application/gzip