Properly remove process from map of registered processes in BpelServerImpl.java
(and some logging consistency)
--------------------------------------------------------------------------------------------------------------
Key: ODE-204
URL: https://issues.apache.org/jira/browse/ODE-204
Project: ODE
Issue Type: Bug
Components: Axis2 Integration
Affects Versions: 1.1
Environment: ODE 1.1
Axis2 Distro
JDK 1.5.0_10
Jetty 6.1.1
Reporter: Richard Taylor
Priority: Trivial
Fix For: 1.1.1, 1.2
First item:
Wanted to add consistency to the logging messages when deploying a new process
1. When deploying, the term "Activated" is used. However when undeploying,
the term "Unregistered" is used.
2. When deploying a new process, the log says "Process foo-1 has been
unregistered", even if a no previous versions of foo were deployed. This was
due to accidentally putting the log call outside of a conditional
Second item:
I haven't seen any direct affects from this code, but it is a bit off. "p" is
never assigned a value before being referenced. From
BpelServerImpl.java:
------------------------------------
BpelProcess p = null;
if (_engine != null) {
_engine.unregisterProcess(pid);
_registeredProcesses.remove(p);
}
Seems it should be something like this:
------------------------------------
BpelProcess p = null;
if (_engine != null) {
p = _engine.unregisterProcess(pid);
if (p != null)
{
_registeredProcesses.remove(p);
}
}
A patch will be attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
