[ https://issues.apache.org/jira/browse/ODE-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ciaran Jessup updated ODE-192: ------------------------------ Attachment: DeleteByInstanceId.patch A patch to fix Issue 2 ;) As far as I can tell the InstanceFilter code strips out any operators on the 'iid' filters, so it is not currently possible to specify a (un)boundede range of instance ids. I've checked the HibernateDAO implementation and it will only ever match a single iid, so I've replicated that code in the JPA implementation, the MEMDAO implementation doesn't seem to bear any reality to the other two, so I've left it be ;) This patch allows the delete method to accept a filter such as iid=1234. It will then as per the comment return '1234' if it was able to delete it. As a side note, if JPA is anything like Hibernate the current approach to deleting all instances won't scale too well as it iterates over every record in the table, deleting each in turn, does JPA support bulk deletes as hibrnate does? Also it may be better (imho) to return rows deleted, rather than instance ids, as deleting all instances could return a huge number of ids ;) > Delete instance call on Management API fails > -------------------------------------------- > > Key: ODE-192 > URL: https://issues.apache.org/jira/browse/ODE-192 > Project: ODE > Issue Type: Bug > Components: BPEL Runtime > Environment: Axis2 Distro > Jetty 6.1.1 > WinXP 64 > JDK 1.5.0_10 > Reporter: Richard Taylor > Fix For: 1.2 > > Attachments: DeleteByInstanceId.patch, DeleteInstanceIssue.zip, > FixDeleteInstances.patch, stacktrace.txt > > > When trying to delete a single instance via the PMAPI it appears that all > instances are deleted and Ode is left in an unstable state. I am using the > JPA persistence which I'm assuming is the default. > The problem appears to be in BPELDAOConnectionImpl.java in the > instanceQuery() method. If I debug down to this method, the "criteria" > parameter has been properly built with my filter (i.e. iid=54) but it is not > properly utilized in the query. There is a TODO note to "finish the > implementation" -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.