[
https://issues.apache.org/jira/browse/ODE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650275#action_12650275
]
Matthieu Riou commented on ODE-429:
-----------------------------------
Sorry I forgot to comment on your first patch. I had a look at it last week and
it looked pretty good to me. My biggest issue was that you were catching
Throwable instead of ClassNotFoundException to activate the JAXP implementation
(as indicated in your code). This could be a problem when one wants to use
Jaxen or Saxon but an unrelated exception occurs at activation (say they have
an older version). In that case the exception is swallowed and tracking down
the problem would be pretty hard.
Your second patch seems to have this same issue but I'll have a look at your
additions. In the meantime if you could fix the problem I just mentioned,
that'd be swell.
Thanks a lot for your work!
> Patch to make Saxon and Jaxen optional for XPath 1.0 processing
> ---------------------------------------------------------------
>
> Key: ODE-429
> URL: https://issues.apache.org/jira/browse/ODE-429
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Compilation/Parsing, BPEL Runtime
> Affects Versions: 2.0
> Reporter: Jürgen Schumacher
> Fix For: 2.0
>
> Attachments: ode-xpath1-jaxp-2008-11-24.patch, ode-xpath1-jaxp.patch
>
>
> See
> http://ode.markmail.org/search/?q=saxon+jaxen#query:saxon%20jaxen+page:1+mid:3sramehxzsfceg76+state:results
>
> This patch adds classes for XPath 1.0 compilation and evaluation based only
> on JAXP interfaces, independent on any specific JAXP implementation. It's
> selected as a fallback in the BPELCompilers if instantiating the existing
> XPath-1.0-implementation based on Jaxen (and Saxon for doXslTransform) fails.
> This enables us to remove Jaxen and Saxon from the classpath which are not
> accepted by the Eclipse foundation because of legal issues (code provenance
> problems...). So the default behaviour of ODE should be the same as without
> these changes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
