SoapExternalService#writeHeader myRoleMessionId passed by coincidence
---------------------------------------------------------------------
Key: ODE-459
URL: https://issues.apache.org/jira/browse/ODE-459
Project: ODE
Issue Type: Improvement
Reporter: Alexis Midon
In SoapExternalService#writeHeader,
PartnerRoleMessageExchange#getMyRoleEndpointReference is converted into a
WSAEndpoint.
The myRoleSessionId is then assigned to this WSAEndpoint reference.
The issue is that the WSAEndpoint reference is never set on the odeMex.
This is a code smell: the myRoleSessionId is passed around only because
odeMex.getMyRoleEndpointReference() is a WSAendpoint instance
and that org.apache.ode.bpel.epr.EndpointFactory.convertToWSA() returns "this"
in that case.
So the code relies on the fact that odeMex.getMyRoleEndpointReference() will
always be a WSAEndpoint instance.
If it's a valid assumption then the call to EndpointFactory#convertToWSA is
unnecessary and could be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
