[
https://issues.apache.org/jira/browse/ODE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725353#action_12725353
]
Alexis Midon edited comment on ODE-626 at 6/29/09 2:18 PM:
-----------------------------------------------------------
#1. Regarding an eventual factory method to instantiate JobDetails, I'm
wondering why we need an interface in the first place. JodDetails is a pojo and
I can't think of any other implementations. I think the interface & factory is
trying to solve an issue that does not exist yet, which is not good. So my
opinion is: delete the interface JobDetails, rename JobDetailsImpl into
JobDetails.
#2. Regarding ProcessCleanUpRunnable, RuntimeDataCleanupRunnable, I think Sean
will know. I'll ping him for feedback.
#3 why should we keep the WorkEvent class? The purpose of this class was to
"wraps around job detail map", witch is what your patch solves. I would remove
the WorkEvent class and use JodDetails instead.
#4 don't you think we could maintain compatibility between old (packed) jobs
and the new (unpacked) ones? This could spare a lot of migration pain for
existing databases. JdbcDelegate#dequeueImmediate could check the detailsExt
map for old keys and assign values to the corresponding new instance attributes.
was (Author: alexismidon):
#1. Regarding an eventual factory method to instantiate JobDetails, I'm
wondering why we need an interface in the first place. JodDetails is a pojo and
I can't think of any other implementations. I think the interface & factory is
trying to solve an issue that does not exist yet, which is not good. So my
opinion is: turns JodDetail into a class, delete JobDetailsimpl.
#2. Regarding ProcessCleanUpRunnable, RuntimeDataCleanupRunnable, I think Sean
will know. I'll ping him for feedback.
#3 why should we keep the WorkEvent class? The purpose of this class was to
"wraps around job detail map", witch is what your patch solves.
#4 don't you think we could maintain compatibility between old (packed) jobs
and the new (unpacked) ones? This could spare a lot of migration pain for
existing databases. JdbcDelegate#dequeueImmediate could check the detailsExt
map for old keys and assign values to the corresponding new instance attributes.
> Unpack details blob from ODE_JOB table
> --------------------------------------
>
> Key: ODE-626
> URL: https://issues.apache.org/jira/browse/ODE-626
> Project: ODE
> Issue Type: Improvement
> Components: BPEL Runtime
> Affects Versions: 2.0
> Reporter: Rafal Rusin
> Assignee: Rafal Rusin
> Fix For: 2.0
>
> Attachments: unpackJobDetails.patch
>
>
> Related discussion is here:
> http://markmail.org/thread/iiy6utvsqew6nn6m
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
