[
https://issues.apache.org/jira/browse/ODE-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832301#action_12832301
]
Rafal Rusin commented on ODE-751:
---------------------------------
I tried this patch. It applied fine.
However I see two problems with this patch:
- tests don't pass, so basicly it doesn't work - you can at least try "buildr
clean test" from bpel-test and jbi subdirectories
- there's a lot of new methods "equals" and "hashcode", which are scarry to
commit, because they will be hard to maintain and not nedded actually. So I
suggest to delete them. Additionally they throw exceptions, like below.
[junit] at java.util.HashMap$Entry.hashCode(HashMap.java:764)
[junit] at java.util.AbstractMap.hashCode(AbstractMap.java:557)
[junit] at org.apache.ode.bpel.rtrep.v2.OScope.hashCode(OScope.java:198)
[junit] at
org.apache.ode.bpel.rtrep.v2.OPartnerLink.hashCode(OPartnerLink.java:217)
[junit] at java.util.HashMap$Entry.hashCode(HashMap.java:764)
[junit] at java.util.AbstractMap.hashCode(AbstractMap.java:557)
[junit] at org.apache.ode.bpel.rtrep.v2.OScope.hashCode(OScope.java:198)
[junit] at
org.apache.ode.bpel.rtrep.v2.OPartnerLink.hashCode(OPartnerLink.java:217)
[junit] at java.util.HashMap$Entry.hashCode(HashMap.java:764)
[junit] at java.util.AbstractMap.hashCode(AbstractMap.java:557)
[junit] at org.apache.ode.bpel.rtrep.v2.OScope.hashCode(OScope.java:198)
[junit] at
org.apache.ode.bpel.rtrep.v2.OPartnerLink.hashCode(OPartnerLink.java:217)
[junit] at java.util.HashMap$Entry.hashCode(HashMap.java:764)
[junit] at java.util.AbstractMap.hashCode(AbstractMap.java:557)
[junit] at org.apache.ode.bpel.rtrep.v2.OScope.hashCode(OScope.java:198)
[junit] at
org.apache.ode.bpel.rtrep.v2.OPartnerLink.hashCode(OPartnerLink.java:217)
> FindBugs Patches for ODE Runtime
> --------------------------------
>
> Key: ODE-751
> URL: https://issues.apache.org/jira/browse/ODE-751
> Project: ODE
> Issue Type: Bug
> Components: BPEL Runtime
> Environment: linux
> Reporter: David Carver
> Assignee: Rafal Rusin
> Attachments: ode-751-patch.txt, ode-bpel-compilepatchv1.txt,
> ode-bpel-runtimepatchv1.txt, ode-bpel-store-patchv1.txt,
> ode-dao-hibernate-patchv1.txt, ode-engine-patchv1.txt,
> ode-il-common-patchv1.txt, ode-jacob-patchv1.txt, ode-jbi-patchv1.txt,
> ode-jca-rapatchv1.txt, ode-jca-serverpatchv1.txt, odebpelapipatchv2.txt,
> odebpeldapatchv1.txt, odebpelpatch.txt, odeutilspatchv1.txt,
> schedule-simple-patchv1.txt
>
>
> Running FindBugs (http://findbugs.sourceforge.net/) against the bpel-api
> project, the following error:
> Equals method for org.apache.ode.bpel.iapi.Endpoint assumes the argument is
> of type Endpoint
> Will attach a patch to correct these issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
