[ 
https://issues.apache.org/jira/browse/ODE-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833549#action_12833549
 ] 

Rafal Rusin commented on ODE-751:
---------------------------------

Two small comments on this patch: 
- let's not modify equals and hashcode methods for now, since it adds messy code
- please use 4 spaces code indenting instead of tabs

After those fixes, it looks good to apply. 

Regards

> FindBugs Patches for ODE Runtime
> --------------------------------
>
>                 Key: ODE-751
>                 URL: https://issues.apache.org/jira/browse/ODE-751
>             Project: ODE
>          Issue Type: Bug
>          Components: BPEL Runtime
>         Environment: linux
>            Reporter: David Carver
>            Assignee: Rafal Rusin
>         Attachments: ode-staticinner-patch.txt
>
>
> Running FindBugs (http://findbugs.sourceforge.net/) against the bpel-api 
> project, the following error:
> Equals method for org.apache.ode.bpel.iapi.Endpoint assumes the argument is 
> of type Endpoint
> Will attach a patch to correct these issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to