[
https://issues.apache.org/jira/browse/ODE-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Carver updated ODE-796:
-----------------------------
Attachment: ode1.x-796-v1.txt
Here is a patch that addresses a few of the bugs that FindBugs found. There
are a couple of others that I could fix, but may just leave them. I do have
one question though on a Serliazable possible bug that was found on
CorrelationKeySetComparator which is an inner class that is Serizable.
FindBugs is suggesting that inner classes shouldn't be serializable:
This Serializable class is an inner class. Any attempt to serialize it will
also serialize the associated outer instance. The outer instance is
serializable, so this won't fail, but it might serialize a lot more data than
intended. If possible, making the inner class a static inner class (also known
as a nested class) should solve the problem.
I could make it a static inner class and remove the serializable but wasn't
sure if that would affect anybody if they already had some of these objects
serialized and needed to restore them after this patch was applied.
> FindBugs Patches for bpel-api project
> -------------------------------------
>
> Key: ODE-796
> URL: https://issues.apache.org/jira/browse/ODE-796
> Project: ODE
> Issue Type: Bug
> Affects Versions: 1.3.3
> Reporter: David Carver
> Priority: Minor
> Attachments: ode-1.x-bpel-runtime-bugs.xml, ode1.x-796-v1.txt
>
>
> This is a tracking bug for the set of patches for the issues reported by
> FindBugs.
> Attaching an XML file that lists the possible bugs. This can be imported in
> FindBugs and viewed there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
