Hi Waruna, Do we have a jira for this issue? I've had a fix that works in my local box, will make a commit it later, so was wondering what the JIRA issue it is.
Regards Jeff On Thu, Oct 28, 2010 at 2:58 PM, Waruna Ranasinghe <waruna...@gmail.com>wrote: > On 28 October 2010 08:09, Jeff Yu <jeff.yuch...@gmail.com> wrote: > > > Hi Waruna, > > > > I am working on the https://issues.apache.org/jira/browse/ODE-864, an > > issue > > related to the undeployment logic as well. My thought for this would be > > that: > > > > we can check if the process that we are trying to undeploy is the last > one, > > say there are no previous versions with it, we then invoke deactivate(), > in > > this case, it would solve my problem and yours. > > > > What do you think? > > > +1 > > Thanks, > Waruna > > > > > > Regards > > > > Jeff > > On Tue, Oct 26, 2010 at 3:13 PM, Waruna Ranasinghe <waruna...@gmail.com > > >wrote: > > > > > On 26 October 2010 09:29, Waruna Ranasinghe <waruna...@gmail.com> > wrote: > > > > > > > Hi devs, > > > > > > > > When a process is undeployed, in BpelProcess#deactivate() method, it > > > checks > > > > whether the process is ACTIVE and call > > > deactivateMyRoleEndpoint(endpoint). > > > > But, what if the process is retired and this process is the only > > process > > > of > > > > its type, then the deactivateMyRoleEndpoint(endpoint) will not be > > called > > > and > > > > the respective axis service will not be removed. > > > > > > > > IMO, we don't need to check whether the process is active, but make > > sure > > > > that the size of _myEprs map is zero for the processes that is not > the > > > > latest version of its type. > > > > > > > Ok, I think we cannot empty _myEprs map for the older versions since > > there > > > may be instances that are not completed yet. > > > > > > But still we need to fix undeployment issue which is mentioned in the > > > previous post. > > > > > > Thanks, > > > Waruna > > > > > > > > > > WDYT? > > > > > > > > > > > > Thanks, > > > > Waruna > > > > > > > > -- > > > > ----------------------------------------------------- > > > > Regards, > > > > Waruna Ranasinghe > > > > > > > > blog: http://warunapw.blogspot.com > > > > twitter: http://twitter.com/warunapww > > > > http://lk.linkedin.com/in/waruna > > > > www.facebook.com/waruna.ranasinghe > > > > > > > > www.wso2.org > > > > > > > > > > > > > > > > -- > > > ----------------------------------------------------- > > > Regards, > > > Waruna Ranasinghe > > > > > > blog: http://warunapw.blogspot.com > > > twitter: http://twitter.com/warunapww > > > http://lk.linkedin.com/in/waruna > > > www.facebook.com/waruna.ranasinghe > > > > > > > > > > > -- > > Cheers, > > Jeff Yu > > > > ---------------- > > blog: http://jeff.familyyu.net > > > > > > -- > ----------------------------------------------------- > Regards, > Waruna Ranasinghe > > blog: http://warunapw.blogspot.com > twitter: http://twitter.com/warunapww > http://lk.linkedin.com/in/waruna > www.facebook.com/waruna.ranasinghe > -- Cheers, Jeff Yu ---------------- blog: http://jeff.familyyu.net
