On Jan 22, 2007, at 11:45 AM, Si Chen wrote:
David,Unfortunately I find this to be somewhat unsatisfactory for two reasons:1. Any potential problem when present should be addressed or at least considered. This bit of code possibly adds a trivial enhancement in the eyes of some users but definitely potential for bugs in the case of other users.2. While it is true that somebody can just correct those on the data entry screen, the fact that this is at the service level rather than just on the screen in a .bsh file means that somebody else might be relying on this service to do things in a way that cannot be corrected on a screen. To the extent the service layer offers a set of APIs in the form of services, such services should work without resorting to corrections in the view layer. One of my favorite things about OFBIZ is the separation of the layers.Still, I agree with you--let's not have a long discussion about small things like this. If I find problems with it down the road with this code I'll fix them myself in a way that's acceptable to all.
Sounds fine to me. -David
smime.p7s
Description: S/MIME cryptographic signature
