[
https://issues.apache.org/jira/browse/OFBIZ-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Huehner updated OFBIZ-770:
---------------------------------
Attachment: ofbiz_isEmpty2.diff
Hi,
this patch converts the rest of the framework to using the isEmpty method for
(==null || .size() == 0).
Three changes used (== null && .size() == 0) which is impossible and the cases
look like bugs where || should have been used. The patch converts these as well
and fixes these bugs. Affected files are:
- EntityJoinOperator
- CatalinaContainer
> Use UtilValidate.is(Not)Empty methods instead of repeated (obj == null) ||
> (obj.size == 0)
> ------------------------------------------------------------------------------------------
>
> Key: OFBIZ-770
> URL: https://issues.apache.org/jira/browse/OFBIZ-770
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: Stefan Huehner
> Priority: Trivial
> Attachments: ofbiz_isEmpty1.diff, ofbiz_isEmpty2.diff
>
>
> Hi,
> this task is to keep track of the conversion of hardcoded isEmpty checks to
> the existing UtilValidate methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
