[ 
https://issues.apache.org/jira/browse/OFBIZ-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482790
 ] 

Adrian Crum commented on OFBIZ-822:
-----------------------------------

Anil,

To test the scalability of your modifications, change the default font size in 
your browser and see what happens.

A few comments on your patches:

Take an objective look at all of the nested divs plus java script in 
CompanyAccountsMenuBar.ftl - does that really seem like less work? Look at the 
page source of the link I posted - notice how it uses simple unordered lists 
with no java script.

GlAccountForms.js.ftl contains only java script, so why use a template? Just 
put this code in a .js file and load it via layoutSettings.javaScripts[] in the 
component's main decorator. Use the Party Manager as an example of how to set 
up component-specific java script files.


> Re-Organize Navigation in Accounting component. 
> ------------------------------------------------
>
>                 Key: OFBIZ-822
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-822
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Anil K Patel
>         Attachments: hotAcctDojo.patch, RefacAccountingMenu.patch, 
> RefacAccountingMenu.patch, RefacAccountingMenu.patch, 
> RefacAccountingMenu.patch
>
>
> Re-Organize navigation in Accounting component. Dojo Widgets to make 
> application more easy to use.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to