[
https://issues.apache.org/jira/browse/OFBIZ-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492917
]
Si Chen commented on OFBIZ-659:
-------------------------------
Anil,
Now that we have the release branch I think this is actually something which we
should be doing in the main SVN trunk. The old order checkout code could
certainly use a lot of enhancing, so if you have the time and interest, this
would be a great contribution.
One suggestion that I have is that the ShoppingCart should be more
object-oriented. For example, ShoppingCartItem should be sub-classing into
FinishedGoodCartItem, DigitalGoodCartItem, RentalCartItem,
FinancialAccountCartItem, etc. etc. They should share common methods in
ShoppingCartItem but type-specific code such as that for reserving room dates
moved into the specific cart item.
Good luck, and thanks for all the contributions!
Si
> Refactoring Create Order process
> --------------------------------
>
> Key: OFBIZ-659
> URL: https://issues.apache.org/jira/browse/OFBIZ-659
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: order
> Reporter: Anil K Patel
> Attachments: OrderCheckoutProcess.patch, OrderCheckoutProcess.patch,
> OrderCheckoutProcess.patch, OrderCheckoutProcess.patch,
> OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch,
> OrderChekOutProcessRefac.patch, OrderChekOutProcessRefac.patch,
> OrderProcessSimpleMethods.patch
>
>
> Focus of this Jira Issue is Refactoring Create Order Process, Implement a
> parallel code as needed so that the current Code remains intact.
> From David's email on Mailing list.
> Just some quick thoughts...
> Following the pattern of the anonymous and other checkout processes
> in the ecommerce app would be a great way to go.
> In the order manager there are various paths through the checkout
> process so we might have, for example, 2 different sets of request-
> map definitions and two different "progress bars", one for sales
> orders and one for purchase orders. These two different sets of high-
> level artifacts can point to the same views, services/events,
> screens, data prep scripts, etc wherever the two processes overlap.
> -David
> My Initial comments
> The anonymous checkout process in Ecommerce component provides some high
> level guiding principals. Few things that I can think of are
> 1) moving some code that's embedded in Java classes into small simple methods.
> 2) Moving process control logic from event handlers to Controller file.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
