[ 
https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504625
 ] 

Jacopo Cappellato commented on OFBIZ-1079:
------------------------------------------

I have quickly reviewed and applied to my local copy the patch.
I will let it run for a while and then I'll commit (if Jacques, or others, will 
comment on it, or beat me it that would be great).
One small thing I don't like much is the setTimeZone code 'hidden' in the 
setSessionLocale method: I understand your motivations (i.e. not changing all 
the controllers) and they make sense, but maybe having it in a new method 
(temporarily called from the setSessionLocale) would be better.... but maybe it 
is a minor issue: what do others think about this?



> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
>                 Key: OFBIZ-1079
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1079
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down 
> list to the masthead. Users can select a time zone and then their selection 
> will be persisted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to