[
https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508725
]
Wickersheimer Jeremy commented on OFBIZ-1096:
---------------------------------------------
Iknow what you mean.
I like to keep everything related in the same place, classes to style the Forms
are in ModelForm, the rendering done in HtmlFormRenderer can then retrieve
those classes consistently instead of mixing hard coding and ModeForm getters.
This is easier for maintainers i think. If later we add code that need those
styles, we have only one place to look for them and one place to modify them.
If in the future someone want to change the default CSS of the pager elements i
will be very easy. If in the future we decide that we need to add the custom
styles in the XML, there will be very little to change in the ModelForm code,
and no modifications to make anywhere else in the framework.
For the same reason, i kept the public getter instead of retrieving the
constant directly .
> Enhanced pager for Forms
> ------------------------
>
> Key: OFBIZ-1096
> URL: https://issues.apache.org/jira/browse/OFBIZ-1096
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: form-dtd.patch, form-dtd_2.patch,
> HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch,
> ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files
> in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well
> as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with
> the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk
> version.
> PS: I would like to use this issue to have your comments on another pager
> issue. The current implementation doesn't support pages that display more
> than one list form for the obvious reason that the only the parameters
> VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to
> differentiate the form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
