[
https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515842
]
Adrian Crum commented on OFBIZ-1172:
------------------------------------
Jeremy,
Your patches would have a better chance of being committed if you would put a
little more effort into them.
You are right, your links are missing Freemarker transforms. Take a few minutes
and put them in.
The HTML you copied does not follow the HTML/CSS Best Practices - see
http://docs.ofbiz.org/display/OFBADMIN/Best+Practices+Guide
There is no need to put <div> elements inside <td> elements. I understand
that's how it was done in the code you copied from, but still, we need to stop
copying bad code.
> Order Entry unclear error when no ProductStore set
> --------------------------------------------------
>
> Key: OFBIZ-1172
> URL: https://issues.apache.org/jira/browse/OFBIZ-1172
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Wickersheimer Jeremy
> Priority: Minor
> Attachments: ofbiz-1172.patch
>
>
> I ran into this issue because our staff accidentally removed the ProductStore
> from the OrderEntry Website. The symptom was an java NPE display when trying
> to create a Purchase Order.
> Because it took me some time to debug it i wrote a patch to make this
> behavior more obvious.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
