[
https://issues.apache.org/jira/browse/OFBIZ-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517956
]
Adrian Crum commented on OFBIZ-1170:
------------------------------------
Jacques,
It would be preferable to commit the NewFreeMarkerWorker.patch because it
addresses a common complaint about Freemarker templates in OFBiz - the
Freemarker <#include> directive doesn't always work.
In addition, the old code created a Configuration instance for every Template
instance, and then put them in the Template cache. The new code shares one
Configuration instance between all template instances - reducing the amount of
memory used in the template cache.
> FreeMarkerWorker class has a bug in its caching logic
> -----------------------------------------------------
>
> Key: OFBIZ-1170
> URL: https://issues.apache.org/jira/browse/OFBIZ-1170
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Adrian Crum
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch,
> FreeMarkerWorker.patch, FreeMarkerWorker.patch, FreeMarkerWorker.patch,
> FreeMarkerWorker.patch, NewFreeMarkerWorker.patch, NewFreeMarkerWorker.patch,
> NewFreeMarkerWorker.patch
>
>
> The FreeMarkerWorker class creates an instance of the Template class,
> initializes it with the current user's locale, then stores it in a cache.
> Other users will see the template rendered in the first user's locale,
> regardless of their locale setting.
> This can be demonstrated on the Hot Wax demo site in the WorkEffort calendar.
> Some elements in the screen are rendered in another locale, regardless of
> your current locale setting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
