Adam, these are super helpful changes where everyone would definitely benefit. The process is definitely to send these thru JIRA, so please start to do that. Put it in batches that make sense so that more than one person can help to tear thru them.

As David, sent along when Ean alluded to this earlier, we'd certainly welcome more committers, we just have to go thru the process

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595


On Sep 13, 2007, at 12:00 AM, Adam Heath wrote:

I've noticed that ofbiz forces javac into 1.5 mode. Then uses generics
in a *few* places thru-out the code.

Are there plans to make this more prevalent?

I've started work on doing that.  This work is two-fold; one, it helps
catch any casting issues. Two, it's a code review. I've actually found logic errors(public Set keySet() { return this.keySet(); }) while adding
all the markup.

I know how ofbiz likes to have changes sent thru jira; but these patches
could touch alot of code.  Asking for write access might not be the
right approach, so I'm wondering what the best way to proceed would be.

==
[EMAIL PROTECTED]:/job/ofbiz/ofbiz-svn/framework/base$ svk diff
src/base/|diffstat
...
 36 files changed, 743 insertions(+), 905 deletions(-)
[EMAIL PROTECTED]:/job/ofbiz/ofbiz-svn/framework/base$ xclipboard
==

Things to note: UtilCache is now generified; so are classes in
util/collections.  I'm still going thru everything, but it goes quite
quickly. I'm making certain that the external apis don't change either.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to