[
https://issues.apache.org/jira/browse/OFBIZ-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527695
]
Jacopo Cappellato commented on OFBIZ-1086:
------------------------------------------
Thomas, thank you for the patch; Christian, thank you for the review and
comment.
In my opinion Christian is right: we cannot include this patch as is now; the
solution proposed by Christian is interesting but maybe the best solution is to
include the logic inside of the ShoppingCart.getDisplayGrandTotal() method. And
instead of testing for (shoppingCart.getTotalSalesTax() > 0.0) we should look
at the ProductStore.showPricesWithVatTax (or a similar flag).
I mean something like this (in pseudocode):
public double getDisplayGrandTotal() {
if (ProductStore.showPricesWithVatTax equals to Y) {
return this.getDisplaySubTotal() + this.getTotalShipping() +
this.getTotalSalesTax() + this.getOrderOtherAdjustmentTotal();
} else {
return getGrandTotal();
}
}
And then in the ecommerce we could simply use the
ShoppingCart.getDisplayGrandTotal() method everywhere.
> Show prices incl. VAT in shoppingcart Total and miniproductsummary
> ------------------------------------------------------------------
>
> Key: OFBIZ-1086
> URL: https://issues.apache.org/jira/browse/OFBIZ-1086
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce, order
> Affects Versions: SVN trunk
> Reporter: Thomas Herzog
> Fix For: SVN trunk
>
> Attachments: carttotal_miniproductsummary_prices__incl_VAT.diff
>
>
> In current implementation of VAT displays a mixture of incl. and excl. prices
> in some ecommerce screens. This patch shows prices incl. VAT for Mini
> Shopping Cart Total, Micro Shopping Cart Total (displayed in the Header),
> Last Products Minibox and Quick Reorder... Minibox.
> It also solves issuses left open in OFBIZ-113.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
