[
https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527736
]
Bilgin Ibryam commented on OFBIZ-1227:
--------------------------------------
Yes, partyId is not used, thats why i removed it.
>> if you add a product with survey to shopping cart and try to see the survey,
>> the given link is broken
>I couldn't reproduce this bug. More details, please?
>From Order manager, Order entry. Then from 'Browse Categories left menu'
>choose Account Activation category, then Financial Account Activation
>(FA-001) .
After adding this product to cart, in shopping cart items there is broken link
"Surveys:" .
After the order creation, in order view screen, there is again a link (it works
but shows all the responses to this survey).
I propose both links to show the EditSurveyResponse screen.
>I searched Ecommerce module, but couldn't find any references to
>"ViewSurveyResponses".
There is no references to "ViewSurveyResponses". (In ecommerce, profile,
surveys, take Survey, after finishing the survey, there is another bug, but i
could not fix it and it is not related to this issue. So i didnot report it. )
>I also tried using the OrderMgr module to test the surveys. There's a bug in
>there, surveys cannot be responded to (error msg "You have >already responded
>to this survey; >multiple responses are not allowed").
How you test the surveys from OrderMgr, More details, please?
Today while testing on the demo server https://demo.hotwaxmedia.com i found
another bug.
If you try to add the same product Financial Account Activation (FA-001) from
OrderMgr, after entering the 'Activation Serial Number:' and submitting the
form, the request goes here and generates error:
ordermgr/controller.xml:477
<request-map uri="additemsurvey">
<security https="false" auth="false"/>
it should be https="true" auth="true" Is there a reason for not doing so?
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey,
> the given link is broken. I add some code the get the surveyId from
> surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1)
> you will get all the surveys stating with id=1, but at this stage the survey
> menu will appears, thinking that we choose a survey with id 1. And this
> survey menu is broken(surveyId=1, it is only a search criteria, not an
> existing survey id). Removing some unused fields from FindSurveyscreen and
> CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from
> shopping cart and order review screens ) from ViewSurveyResponses to
> EditSurveyResponse. If we change it, clicking on the survey link from an
> order/shoppingcart item, will show us the exact survey response and ability
> to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
