[
https://issues.apache.org/jira/browse/OFBIZ-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528923
]
Bilgin Ibryam commented on OFBIZ-689:
-------------------------------------
Hi guys,
I just took a look at this patch and did some changes and comments:
1. Added another function that highlight all the fields when clicked on select
all check box.
2. Removed viewOneTR2 class from highlightRow function. This class is not used
in ofbiz at all and it makes some bugs (in some cases some of the rows are
styled viewOneTR2 and some viewOneTR1, they are close but different color
styles).
In ofbiz there are also some other tables that can benefit from this checkbox
highlight feature. Why not add these javascript functions to selectall.js
insetead of concrete ftl files?
An alternative way to go could be applying "hover-bar" style to the form table.
I mean something like this:
Index:
applications/product/webapp/catalog/feature/EditFeatureCategoryFeatures.ftl
===================================================================
--- applications/product/webapp/catalog/feature/EditFeatureCategoryFeatures.ftl
(revision 577453)
+++ applications/product/webapp/catalog/feature/EditFeatureCategoryFeatures.ftl
(working copy)
@@ -53,7 +53,7 @@
</tr>
</table>
</#if>
-<table border="1" cellpadding='2' cellspacing='0'>
+<table border="1" cellpadding='2' cellspacing='0' class="hover-bar">
<form method='POST'
action='<@ofbizUrl>UpdateProductFeatureInCategory</@ofbizUrl>'
name="selectAllForm">
<input type="hidden" name="_useRowSubmit" value="Y">
<input type="hidden" name="_checkGlobalScope" value="N">
Bilgin Ibryam
> Highlight Selected Feature
> --------------------------
>
> Key: OFBIZ-689
> URL: https://issues.apache.org/jira/browse/OFBIZ-689
> Project: OFBiz
> Issue Type: New Feature
> Components: product
> Reporter: Anil K Patel
> Assignee: Scott Gray
> Attachments: HighlightSelectedRow.patch
>
>
> When we pick a category and we get a list of specific feature, since usually
> it is a long list and you might be clicking a box that is not on the same
> level than the feature you wanted to pick, to avoid mistakes, can you
> highlight the whole line once the box is checked to make sure that the box
> checked was the one of the option we wanted
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
