[ 
https://issues.apache.org/jira/browse/OFBIZ-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530411
 ] 

David E. Jones commented on OFBIZ-1258:
---------------------------------------

Adrian I reviewed your comments and the patch and I'm not sure if I like, or 
understood the point of, all of the changes.

In SVN rev 579571 I did fix up the sync block for the cache get/put in the 
renderTemplateFromString method, which I think was the main thing you were 
trying to fix.

Please let me know what else needs to be fixed or cleaned up. One thing I 
didn't want to do is add a bunch of methods that aren't really needed (there is 
a HUGE proliferation of this sort of method in OFBiz and in spite of the intent 
I think this makes that APIs more difficult to use instead of easier).

> Improved FreeMarkerWorker
> -------------------------
>
>                 Key: OFBIZ-1258
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1258
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: FreeMarkerWorker.patch, FreeMarkerWorker.patch
>
>
> Minor fixups for the recent changes to the file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to