Re: svn commit: r580760 - /ofbiz/trunk/applications/content/widget/CommonScreens.xml

[David E Jones]

The selectall.js file, or any other js file, should not go in a general 
decorator, especially an application-wide one like mainContentDecorator. It 
should go in each individual screen that actually uses/needs the JavaScript.

This is important for efficient functioning of the applications (avoid loading 
unused files, which need to be requested for every page hit in HTTPS), and also 
to reduce problems with naming and other conflicts in the per-page scripting 
contexts.

-David


[EMAIL PROTECTED] wrote:

Author: jleroux
Date: Sun Sep 30 11:08:19 2007
New Revision: 580760

URL: http://svn.apache.org/viewvc?rev=580760&view=rev
Log:
From a David Goodenough's issue "Missing .js file when searching for 
DataResource" (https://issues.apache.org/jira/browse/OFBIZ-1272) - OFBIZ-1272

Modified:
    ofbiz/trunk/applications/content/widget/CommonScreens.xml

Modified: ofbiz/trunk/applications/content/widget/CommonScreens.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/widget/CommonScreens.xml?rev=580760&r1=580759&r2=580760&view=diff
==============================================================================
--- ofbiz/trunk/applications/content/widget/CommonScreens.xml (original)
+++ ofbiz/trunk/applications/content/widget/CommonScreens.xml Sun Sep 30 
11:08:19 2007
@@ -36,9 +36,10 @@
                 <set field="layoutSettings.extraHead" value="&lt;link rel=&quot;stylesheet&quot; 
href=&quot;/content/images/contentForum.css&quot; type=&quot;text/css&quot;/&gt;"/>
                 <!-- <set field="layoutSettings.headerMiddleBackgroundUrl" value="" 
global="true"/> -->
                 <!-- <set field="layoutSettings.headerRightBackgroundUrl" value="" 
global="true"/> -->

+ <set field="layoutSettings.javaScripts[]" value="/images/selectall.js" global="true"/> <set field="activeApp" value="contentmgr" global="true"/>

                 <set field="applicationMenuName" value="ContentAppBar" 
global="true"/>
-                <set field="applicationMenuLocation" 
value="component://content/widget/content/ContentMenus.xml" global="true"/>

+ <set field="applicationMenuLocation" value="component://content/widget/content/ContentMenus.xml" global="true"/> </actions>

             <widgets>
                 <include-screen name="GlobalDecorator" 
location="component://common/widget/CommonScreens.xml"/>