Re: svn commit: r580760 - /ofbiz/trunk/applications/content/widget/CommonScreens.xml

[David E Jones]

Jacques,

I think on this... nevermind. I looked into the specific method that was a 
problem in the issue and it is one used for pretty much ALL html forms 
generated by the form widget, so including it somewhere high level like this is 
fine.

The selectall.js file is the problem and should be split up to have the more 
generic ones includ-able in all screens, and the more specific ones (like the 
toggle* and selectAll* methods in there) into a file that can be included more 
locally. Of course, that should be done for other js files in OFBiz too... and 
this would be a lot of work and there are bigger issues to work on (like 
automated tests... for example).

-David


Jacques Le Roux wrote:

David,

The reason I put it there is because there are no easy identifiable screens. 
The only place I found submitFormDisableSubmits is in
HtmlFormRenderer.renderFormOpen. What is the best practice in such case ? 
Because I can't see a quick way to find concerned screens.

Thanks

Jacques


De : "David E Jones" <[EMAIL PROTECTED]>

The selectall.js file, or any other js file, should not go in a general 
decorator, especially an application-wide one like

mainContentDecorator. It should go in each individual screen that actually 
uses/needs the JavaScript.

This is important for efficient functioning of the applications (avoid loading 
unused files, which need to be requested for every

page hit in HTTPS), and also to reduce problems with naming and other conflicts 
in the per-page scripting contexts.

-David


[EMAIL PROTECTED] wrote:

Author: jleroux
Date: Sun Sep 30 11:08:19 2007
New Revision: 580760

URL: http://svn.apache.org/viewvc?rev=580760&view=rev
Log:
From a David Goodenough's issue "Missing .js file when searching for 
DataResource"

(https://issues.apache.org/jira/browse/OFBIZ-1272) - OFBIZ-1272

Modified:
    ofbiz/trunk/applications/content/widget/CommonScreens.xml

Modified: ofbiz/trunk/applications/content/widget/CommonScreens.xml
URL:

http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/widget/CommonScreens.xml?rev=580760&r1=580759&r2=580760&view=diff

==============================================================================
--- ofbiz/trunk/applications/content/widget/CommonScreens.xml (original)
+++ ofbiz/trunk/applications/content/widget/CommonScreens.xml Sun Sep 30 
11:08:19 2007
@@ -36,9 +36,10 @@
                 <set field="layoutSettings.extraHead" value="&lt;link 
rel=&quot;stylesheet&quot;

href="/content/images/contentForum.css" 
type="text/css"/>"/>

                 <!-- <set field="layoutSettings.headerMiddleBackgroundUrl" value="" 
global="true"/> -->
                 <!-- <set field="layoutSettings.headerRightBackgroundUrl" value="" 
global="true"/> -->
+                <set field="layoutSettings.javaScripts[]" value="/images/selectall.js" 
global="true"/>
                 <set field="activeApp" value="contentmgr" global="true"/>
                 <set field="applicationMenuName" value="ContentAppBar" 
global="true"/>
-                <set field="applicationMenuLocation" 
value="component://content/widget/content/ContentMenus.xml"

global="true"/>

+                <set field="applicationMenuLocation" 
value="component://content/widget/content/ContentMenus.xml"

global="true"/>

             </actions>
             <widgets>
                 <include-screen name="GlobalDecorator" 
location="component://common/widget/CommonScreens.xml"/>