I have applied and tested several of these changes against an older custom codebase currently in production and they seem to be working well. The attention is much appreciated and I will leave comments in JIRA, as I do not have framework commit privileges.

-Joe

On Oct 3, 2007, at 4:43 PM, David E Jones wrote:


Testing on these would be really great.

Based on a brief review some of them look good and pretty low risk, but any may have side effects, and for some it seems likely to me (like the changing where the listener thread is started... that can be REALLY bad in production when requests flood in and webapp data is only partially loaded and such). On that and any of them I haven't looked at the details yet, these are just thoughts based on reading the names and short descriptions.

So yeah, as with all other issues testing and feedback is enormously valuable, the most important thing in fact.

-David


On Oct 3, 2007, at 2:32 PM, Adrian Crum wrote:

Adam,

I'll have some time this weekend to test your patches.

-Adrian

Adam Heath wrote:

So, you've all seen the jira issues I've filed, all with patches
attached. I need those applied, so I can start feeding the large set of
changes I have.
Namely, I have a 10000 line patch against all of framework, adding the
following features:
1: generics markup
2: varargs
3: enhanced-for
4: *some* auto-boxing
I have plans on how I want to split it up, but my work would be much
simpler if someone would apply the patches I've already sent.



Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to