Jacopo,
Right now I'm doing a simple move. I'm moving the permissions checking logic found in
PartyServices.java to the permission service simple methods. I wasn't planning on refactoring
anything. So, if the ROLE based permission checks are already in PartyServices.java, then yes, I
will be working on them.
The only reason I brought up the extended permissions issue was because I was going to make the move
without changing anything, but while doing so I noticed the existing permissions check didn't have
the desired result.
-Adrian
Jacopo Cappellato wrote:
Jacopo Cappellato wrote:
Adrian Crum wrote:
...
I propose checking the current extended permissions in the following
way: Check for the base PARTYMGR permission first, if that fails,
then check the extended (PARTYMGR_STS) permission. Example: the
setPartyStatus service would check for the PARTYMGR_UPDATE permission
first, and if that fails, it would then check for the
PARTYMGR_STS_UPDATE permission.
...
What do you think?
Adrian, are you going to work also on the ROLE based permissions checks?
They are trickier but it would be great to refactor them too.
Jacopo
