[ 
https://issues.apache.org/jira/browse/OFBIZ-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536672
 ] 

polawat phetra commented on OFBIZ-1348:
---------------------------------------

Hi Jack.

  I think there is a problem with your BirtHelper.java and BirtViewHandler 
design.
You should not  use a static field to held a (temporary) session data because 
it will cause a problem when concurrent thread request a report at the same 
time.

Here the problem code which i had make the comment down below.

public class BirtViewHandler implements ViewHandler {

    public void render(String name, String page, String info, String 
contentType, String encoding, HttpServletRequest request, HttpServletResponse 
response) throws ViewHandlerException {

        ...

        String baseURL = request.getScheme( ) + "://" 
                + request.getServerName( ) + ":" 
                + request.getServerPort( );
        String path=context.getRealPath(page);

        //===== THESE TWO LINE WILL CAUSE A PROBLEM WHEN ACCESS FROM CONCURRENT 
THREAD ===//
        BirtViewHelper.PATH = path;
        BirtViewHelper.PERMISSION = info;

        try{                    
                
response.sendRedirect(baseURL+"/birt/control/frameset?"+LoginWorker.EXTERNAL_LOGIN_KEY_ATTR+"="+request.getSession().getAttribute(LoginWorker.EXTERNAL_LOGIN_KEY_ATTR));
            
        }catch( Exception e){}
      
   }

}

> add the BIRT as the ofbiz component
> -----------------------------------
>
>                 Key: OFBIZ-1348
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1348
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: jack_guo
>             Fix For: SVN trunk
>
>         Attachments: AuthenticateHelper.java, birt.zip, BirtViewHandler.java, 
> BirtViewHelper.java, CreateDataSource.java, OfbizScripted.rptdesign, 
> plugins1.zip, plugins2.zip, plugins3.zip, quickStart.doc, screenshot.bmp
>
>
> put the BIRT run environment to the ofbiz, make the BIRT as the ofbiz 
> component, and let the user can develop the BI more easily and efficiently

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to