I disagree. Personally I like methods with optional arguments, especially when these arguments aren't really necessary. When you do not pass the extra arguments, the assumption should be that you get the defaults (default Locale and default TimeZone) which is fine.

In addition, this method was mainly put there for the use of Integer instead of int, since the primitive cannot be used inside an FTL.

Andrew

On Oct 25, 2007, at 7:16 PM, Adrian Crum wrote:

Andrew,

I understand what the method does. The point I'm trying to make is this: It is not needed and it provides a way to introduce inconsistent data into the project.

I understand the method solves a problem for a particular client, but it's not a good thing to include in the project.

There is a discussion on Jira about this:

https://issues.apache.org/jira/browse/OFBIZ-1361

-Adrian

Andrew Zeneski wrote:
This method is to use an int offset to adjust the timestamp, without a locale or timezone. That's it. No hidden meanings here. It uses Integer instead of int since Freemarker doesn't wrap primitives.
On Oct 25, 2007, at 7:05 PM, Adrian Crum wrote:
Andrew Zeneski wrote:

The predicted results will be a timestamp adjusted with with the specific amount specified, without a timezone available. Just a helper method. I used it on a system which is set to GMT and requires dates be displayed in the customer facing in the customer's timezone. The timezone is read as an offset (in javascript) and then adjusted on the fly as needed. There is no TimeZone object available, all we know is how many minutes off GMT.
Andrew


The commit log mentions calling this from Freemarker. There are Locale and TimeZone objects in the Freemarker context. In addition, I'm pretty sure that no matter where you are in the code execution path, you have access to Locale and TimeZone objects.

-Adrian




Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to