[ 
https://issues.apache.org/jira/browse/OFBIZ-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538543
 ] 

Adrian Crum commented on OFBIZ-1237:
------------------------------------

David,

Thank you for taking another look at this. I keep the patch updated because we 
use it here on our local copy.

The recent Generics work threw off the line numbers from my original comment. 
Now we're looking at lines 136, 180, and 189.

So, line 136 copies the ECA action result to the original service's result. 
Then in lines 180 and 189 we try to get the error messages from the original 
service. Oops, they are not there because we just copied over them.

Maybe that's where the confusion is coming in. I'm trying to preserve the 
original behavior of concatanating the error messages even when 
result-to-result is set true. This is important in the permission service 
scenario - you want to see the list of ALL the permissions that failed - the 
original permission service PLUS the ECA action permission service.


> Add the ability to copy ECA action result Map to the service result Map
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-1237
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1237
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Assignee: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ServiceEcaAction.patch, ServiceEcaAction.patch, 
> ServiceEcaAction.patch, ServiceEcaAction.patch
>
>
> The service dispatcher uses the result Map from the initial service invoked 
> and it ignores the result Map of any ECAs that are invoked. So, any values 
> that an ECA service attempts to return are ignored.  It would be preferable 
> to have an action attribute that permits copying the action's result Map to 
> the service's result Map.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to