[ 
https://issues.apache.org/jira/browse/OFBIZ-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540070
 ] 

Jacques Le Roux commented on OFBIZ-1106:
----------------------------------------

Dan,

I tried your patch (on release4.0 since POS is unusable in trunk for now : 
OFBIZ-1385). It works well, good job. Using net.xoetrope.swing.XPassword is 
really the  good idea.

I wil not apply it to release before testing it in trunk (it should work 
without problem) but please see also the following remark about your patch.

For new file you should not put any specific svn:properties (author for 
instance) but as you granted your right to Apache foundation you should put the 
Apache header. Please look into APACHE2_HEADER file in OFBiz root.

In case of doubt please refer to 
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices

Thanks for your work

> Passwords in POS are shown in clear text
> ----------------------------------------
>
>                 Key: OFBIZ-1106
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1106
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: pos
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Chris Lombardi
>            Assignee: Jacques Le Roux
>            Priority: Minor
>         Attachments: input-contents-hidden.patch, input-with-password.patch
>
>
> Passwords entered in the POS are displayed in the clear in the POS input 
> panel.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to